Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 325
    • Issues 325
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #33573
Closed
Open
Issue created Mar 09, 2020 by opara@opara🎄Contributor

Update dir-spec descriptor cosmetic difference criteria (12 hours -> 2 hours)

In section 3.2 of the dir-spec document it says:

If the authority _does_ have a descriptor with the same public key, the
newly uploaded descriptor is remembered if its publication time is more
recent than the most recent old descriptor for that router, and either:

   - There are non-cosmetic differences between the old descriptor and the
     new one.
   - Enough time has passed between the descriptors' publication times.
     (Currently, 12 hours.)

This value of 12 hours was change in commit cc351578 to 2 hours.

In addition, a comment in the tor code still says 12 hours.

This ticket covers two changes:

  • update the dir-spec to say 2 hours
  • update a comment in the tor code

Will attach two PRs shortly.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking