Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 313
    • Issues 313
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #3512
Closed
Open
Created Jul 01, 2011 by Nick Mathewson@nickm👁Owner

Functions that perform hostname lookup should be clearly labeled

Quick quiz: which of the following might do a DNS lookup, and which don't?

A. tor_addr_port_parse() B. parse_addr_port() C. tor_addr_lookup() D. tor_addr_parse_mask_ports() E. tor_addr_from_str() F. parse_addr_and_port_range()

If remembered that A, B, and C can do DNS lookups, but that D, E, and F don't do DNS lookups, then you have a better memory than I.

We should rename the functions here so that everything that does a resolve has "resolve" or "lookup" in its name, and everything that only has "parse" in its name is parsing-only. We should also audit our use of the resolving functions to make sure that we're not calling any of them any place that we shouldn't.

The renaming should hold off till after we've merged the IPv6 conversion, since that touches almost all of the code we'd want to alter here.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking