Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,064
    • Issues 1,064
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • Tor
  • Issues
  • #40019

Closed
Open
Opened Jul 01, 2020 by David Goulet@dgoulet😈Owner

git hooks: Stop running practracker constantly

Practracker runs on every commit with the pre-commit hook. It does not run on maint- branches but it runs on master but also on EVERY development branch anyone does.

The reason is simple, it is that we never merge things that breaks practracker into master so makes sense that every dev branch is tested.

However, I'm arguing here that running practracker constantly is a waste of time and extremely annoying for development.

There is value in practracker but I think we could simply run it once in a while, maybe every release, update the exception file and be done with it. There is even an argument to say that one should only run it in order to measure our technical debt in some ways or wanting to start fixing part of it.

Again, I don't see value in constantly having a perfectly up to date exceptions.txt file. There is value that we have the tool available in our repository but not being run all the time. Yes, it can break but this is why we can simply run it as part of our release process.

Thus I vote to remove it from our pre-commit-git.hook file.

Thoughts @tpo/core ?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: tpo/core/tor#40019