Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 326
    • Issues 326
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #40269
Closed
Open
Issue created Feb 01, 2021 by David Goulet@dgoulet🐼Owner

relay: Avoid false positive on network reentry detection

Bloomfilters are by design probabilistic and thus there is a small chance that we have false positive when looking them up.

When detecting network reentry, a false positive implies that the addr + port destination is then consider a reentry and the connections are refused.

Even though it is rare, that pair could be a very busy destination like wikipedia.org + 443 and so every users at that Exit would be unable to reach that destination.

Move to use an hashtable here (as a set) of addr+port so the lookup is still O(1) but with certainty. The memory footprint will be more important but still below a megabyte for all the relays to be in that set.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking