tor-0.4.5.6: NetBSD test failures
When running the self tests for tor-0.4.5.6 on NetBSD-9.99.80/amd64, I see a few failures.
gmake && gmake check gives me:
/usr/pkg/bin/gmake check-TESTS check-local
gmake[1]: Entering directory '/scratch/net/tor/work/tor-0.4.5.6'
gmake[2]: Entering directory '/scratch/net/tor/work/tor-0.4.5.6'
PASS: src/test/test-slow
PASS: src/test/test-memwipe
PASS: src/test/test_workqueue
PASS: src/test/test_keygen.sh
PASS: src/test/test_key_expiration.sh
PASS: src/test/test-timers
SKIP: src/test/fuzz_static_testcases.sh
PASS: src/test/test_zero_length_keys.sh
PASS: src/test/test_workqueue_cancel.sh
SKIP: src/test/test_workqueue_efd.sh
SKIP: src/test/test_workqueue_efd2.sh
PASS: src/test/test_workqueue_pipe.sh
PASS: src/test/test_workqueue_pipe2.sh
PASS: src/test/test_workqueue_socketpair.sh
SKIP: src/test/test_switch_id.sh
PASS: src/test/test_cmdline.sh
PASS: src/test/test_parseconf.sh
PASS: src/test/unittest_part1.sh
FAIL: src/test/unittest_part2.sh
PASS: src/test/unittest_part3.sh
PASS: src/test/unittest_part4.sh
PASS: src/test/unittest_part5.sh
PASS: src/test/unittest_part6.sh
PASS: src/test/unittest_part7.sh
FAIL: src/test/unittest_part8.sh
PASS: src/test/test_ntor.sh
PASS: src/test/test_hs_ntor.sh
PASS: src/test/test_bt.sh
PASS: scripts/maint/practracker/test_practracker.sh
PASS: scripts/maint/run_check_subsystem_order.sh
PASS: src/test/test_rebind.sh
FAIL: src/test/test_include.sh
PASS: scripts/maint/checkSpaceTest.sh
============================================================================
Testsuite summary for tor 0.4.5.6
============================================================================
# TOTAL: 33
# PASS: 26
# SKIP: 4
# XFAIL: 0
# FAIL: 3
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
============================================================================The test-suite.log file is quite big, I'll attach it.
Nick Mathewson wrote: Looks like a bug in the new wildcard handling for configuration-file includes:
config/include_wildcards:
FAIL src/test/test_config.c:6113:
assert(config_get_lines_include(torrc_contents, &result, 0,
&include_used, NULL) OP_EQ 0): -1 vs 0
[include_wildcards FAILED]
config/include_opened_file_list:
FAIL src/test/test_config.c:6502:
assert(config_get_lines_include(torrc_contents, &result, 0,
&include_used, opened_files) OP_EQ 0): -1 vs 0
[include_opened_file_list FAILED]