Don't exit if a service directory has non-private permissions when using TestingTorNetwork
When running tor with TestingTorNetwork
enabled, don't exit if the hs directory has other/world permissions set.
For Tor experiments with configurations that are tracked in git, it is a bit of a pain to fix up ownership of the configuration files before running tor. To work around this, Shadow puts all of the files in an archive to preserve permissions and commits the archive to git, but it would be nice to be able to commit the configuration files to git directly and track changes properly.
In almost all cases where the permissions are incorrect, tor will automatically fix them and continue running, but the only exception to this that I can find is the hidden service directory.
As the TestingTorNetwork
is explicitly about running a testing Tor network, I don't see any security implications of disabling the permissions check when this option is enabled.
(PR incoming...)