Non-fatal assertion circ->purpose != CIRCUIT_PURPOSE_CONFLUX_LINKED failed in CIRCUIT_IS_CONFLUX at ./src/core/or/conflux_util.h:31

Steps to reproduce:

start your tor
connect to the controlport (authenticate, setevents circ stream)
make a request, (curl -x socks5h://127.0.0.1:9050 seul.org/)
wait 10 minutes (maxcircuitdirtiness)

git bisect leads to:

0892210d10e6ea849a940a977cd9db57be153c0d is the first bad commit
commit 0892210d10e6ea849a940a977cd9db57be153c0d
Author: Mike Perry <mikeperry-git@torproject.org>
Date:   Thu Nov 21 17:08:19 2024 +0000

    Ticket 40872: Output conflux nonce and circ rtt to control port

 src/core/or/conflux_util.c        |  7 +++++--
 src/feature/control/control_fmt.c | 21 +++++++++++++++++++++
 2 files changed, 26 insertions(+), 2 deletions(-)

In circuit_about_to_free() in src/core/or/circuitlist.c, we have

  /* Cleanup conflux specifics. */
  conflux_circuit_about_to_free(circ);
[...]
  if (CIRCUIT_IS_ORIGIN(circ)) {
    circuit_event_status(TO_ORIGIN_CIRCUIT(circ),

and CIRCUIT_IS_CONFLUX() does

  } else if (circ->conflux) {
    if (CIRCUIT_IS_ORIGIN(circ))
      tor_assert_nonfatal(circ->purpose == CIRCUIT_PURPOSE_CONFLUX_LINKED);
    return true;
  } else {
    tor_assert_nonfatal(circ->purpose != CIRCUIT_PURPOSE_CONFLUX_LINKED);

so my first theory is that conflux_circuit_about_to_free() unlinks circ->conflux and then CIRCUIT_IS_CONFLUX() in circuit_describe_status_for_controller() is shocked to find it not linked.

Probably needs some eyes from @dgoulet and/or @mikeperry

changed milestone to %Tor: 0.4.8.x-post-stable

Ah yeah, @arma nailed it... problem is that in CIRCUIT_IS_CONFLUX(), the else { branch asserts that the purpose ain't CONFLUX which is problematic once we actually wiped the circ->conflux object from the circuit but kept the purpose conflux...

We should simply probably remove those asserts else we have to replace the CIRCUIT_IS_CONFLUX() by if (circ->conflux) which looses its purpose ;).

mentioned in merge request !874 (merged)

closed with commit 46161b19

mentioned in issue #41038 (closed)

mentioned in issue tpo/applications/tor-browser#43625 (closed)

Non-fatal assertion circ->purpose != CIRCUIT_PURPOSE_CONFLUX_LINKED failed in CIRCUIT_IS_CONFLUX at ./src/core/or/conflux_util.h:31

Child items ...

Activity