Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 832
    • Issues 832
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #4210

Closed
Open
Created Oct 08, 2011 by Damian Johnson@atagar

Undefined version comparisions

While writing the version parsing for stem I noticed that the version spec [1] doesn't define how to compare empty tags and patch levels. For instance, if "1.2.3.4-myTag" is a greater or lower version than "1.2.3-myTag".

My suggestion would be to add a note that an undefined patch is zero and undefined tag equates to the empty string. Ie...

"1.2.3-myTag" == "1.2.3.0-myTag" "1.2.3.4" == "1.2.3.4-"

Cheers! -Damian

[1] https://gitweb.torproject.org/torspec.git/blob/HEAD:/version-spec.txt

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking