Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 316
    • Issues 316
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #824
Closed
Open
Created Sep 25, 2008 by Trac@tracbot

More accurate calculation of bandwith limits in past.

Buckets decrements with raw bytes for OR connection which more than real bytes. So global write bucket can and do run dry with negative numbers, if Tor transmit cells.

Fix can repair possibly issue with DoS against relay with DirPort reported by Scott Bennett on or-talk some time ago (december '07 and later).

--- connection.original.c Mon Sep 8 13:10:16 2008 +++ connection.c Thu Sep 25 20:44:40 2008 @@ -1718,7 +1718,7 @@ tor_assert(seconds_elapsed >= 0);

write_buckets_empty_last_second =

  • global_relayed_write_bucket == 0 || global_write_bucket == 0;
  • global_relayed_write_bucket <= 0 || global_write_bucket <= 0;

/* refill the global buckets */ connection_bucket_refill_helper(&global_read_bucket,

[Automatically added by flyspray2trac: Operating System: All]

Trac:
Username: rovv

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking