Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 313
    • Issues 313
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Issues
  • #861
Closed
Open
Created Nov 12, 2008 by Roger Dingledine@armaReporter

tor doesn't release log fd on hup if log failed

If my disk fills up and Tor's log stops (write failed or the like), then Tor handles it fine -- it doesn't die:

% lsof|grep tord tor 18060 arma 16w REG 3,5 11517952 782436 /tmp/tord-log

But when I hup tor, I get two handles:

tor 18060 arma 9w REG 3,5 11517952 782436 /tmp/tord-log tor 18060 arma 16w REG 3,5 11517952 782436 /tmp/tord-log

I deleted tord-log, and I still have the handles (makes sense): tor 18060 arma 9w REG 3,5 11517952 782436 /tmp/tord-log (deleted) tor 18060 arma 16w REG 3,5 11517952 782436 /tmp/tord-log (deleted)

But then I hup tor and they're still here: tor 18060 arma 9w REG 3,5 11517952 782436 /tmp/tord-log (deleted) tor 18060 arma 16w REG 3,5 11517952 782436 /tmp/tord-log (deleted) tor 18060 arma 20w REG 3,5 0 783109 /tmp/tord-log

It only happens when I'm out of disk space. So presumably there's something about our seems_dead log entries that makes them not get cleaned when Tor hups.

Bug affects both 0.2.0.x and 0.2.1.x. I didn't check 0.1.2.x.

[Automatically added by flyspray2trac: Operating System: All]

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking