Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Tor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 823
    • Issues 823
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 30
    • Merge requests 30
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • TorTor
  • Merge requests
  • !460

ignore SHARE_DATADIR on Android, it makes no sense there

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open eighthave requested to merge eighthave/tor:main into main Oct 15, 2021
  • Overview 13
  • Commits 1
  • Pipelines 2
  • Changes 1

There is no absolute install path that an app can expect data files on Android. Everything is expected to be a path inside of the app, and those paths depend on the Application ID of the app.

This fixes a reproducible issue where the tor-android build harness ended up including build paths for SHARE_DATADIR.

@n8fr8 FYI

Edited Oct 15, 2021 by eighthave
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: main