memory leak in tor_cert_parse()
Running my Tor relay under valgrind with all the config options that Yawning's sandboxed Tor Browser turns on, I see: ``` ==18287== 708 (288 direct, 420 indirect) bytes in 3 blocks are definitely lost in loss record 55 of 64 ==18287== at 0x4C28C20: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==18287== by 0x262FF7: tor_malloc_ (util.c:150) ==18287== by 0x26308D: tor_malloc_zero_ (util.c:178) ==18287== by 0x1B4972: tor_cert_parse (torcert.c:135) ==18287== by 0x1A4F82: router_parse_entry_from_string (routerparse.c:2035) ==18287== by 0x1A1907: routerlist_reparse_old (routerlist.c:3741) ==18287== by 0x1A1907: update_consensus_router_descriptor_downloads (routerlist.c:5187) ==18287== by 0x1A1C3F: update_all_descriptor_downloads (routerlist.c:4551) ==18287== by 0x147FB2: launch_descriptor_fetches_callback (main.c:1475) ==18287== by 0x166DBF: periodic_event_dispatch (periodic.c:52) ==18287== by 0x53613DB: event_base_loop (in /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5.1.9) ==18287== by 0x14C1E3: run_main_loop_once (main.c:2385) ==18287== by 0x14C1E3: run_main_loop_until_done (main.c:2429) ==18287== by 0x14C1E3: do_main_loop (main.c:2357) ==18287== by 0x14F934: tor_main (main.c:3486) ``` (This is the Tor from my bug20423 branch, which is commit caf742287 from close to the edge of maint-0.2.9 plus two hopefully irrelevant commits -- so I am calling the version 0.2.9.5-alpha.)
issue