tor_cert_decode() memory leak
running on moria1 for a few hours: ``` ==24953== 46,674 (2,560 direct, 44,114 indirect) bytes in 16 blocks are definitely lost in loss record 58 of 60 ==24953== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==24953== by 0x226F77: tor_malloc_ (util.c:144) ==24953== by 0x2285B5: tor_malloc_zero_ (util.c:170) ==24953== by 0x236539: tor_cert_new (tortls.c:738) ==24953== by 0x2377D7: tor_cert_decode (tortls.c:789) ==24953== by 0x18B591: channel_tls_handle_var_cell (channeltls.c:1559) ==24953== by 0x1CEDCF: connection_or_process_cells_from_inbuf (connection_or.c:1913) ==24953== by 0x1C0D73: connection_handle_read (connection.c:2747) ==24953== by 0x11CC30: conn_read_callback (main.c:721) ==24953== by 0x52C9343: event_base_loop (in /usr/lib/libevent-1.4.so.2.1.3) ==24953== by 0x11A5B0: do_main_loop (main.c:1987) ==24953== by 0x11A96C: tor_main (main.c:2699) ``` This is Tor 0.2.4.5-alpha-dev (git-e1c7d12b1d91eea9) plus the one-liner patch from legacy/trac#7420 that shouldn't matter here.
issue