Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor Specifications
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • Tor Specifications
  • Issues
  • #9

Closed
Open
Created Apr 09, 2019 by Iain Learmonth@irl

"pr" lines in consensus can have trailing whitespace

dir-spec specifies keyword lines as:

KeywordLine ::= Keyword NL | Keyword WS ArgumentChar+ NL

However, observed in the wild:

pr 

There is trailing whitespace on line 1840 of the [19:00:00 consensus]. It is at line 1840.

As the directory authorities all seem to agree that this trailing whitespace should be there we don't have an issue, but it's against the spec and has likely happened by accident.

If we accidentally remove the trailing whitespace, we don't have a consensus anymore.

Options for fixing this are:

  • require trailing whitespace for pr lines with no arguments
  • make a new consensus method that doesn't have trailing whitespace

Either way, this needs a spec change before we write any code.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None