Commit dc77970d authored by Damian Johnson's avatar Damian Johnson
Browse files

Don't retry downloading votes 

Honestly I don't recall why we added retries here...

  https://gitweb.torproject.org/doctor.git/commit/?id=5e200e9

Seems this mostly just masked when an authority was unavailable.
parent 3315ad58

.gitignore

+1 −1
Original line number Diff line number Diff line
@@ -4,7 +4,7 @@ logs/ 
data/contact_information.cfg

data/fingerprints

data/fingerprint_changes

data/fingerprint_change_last_notified.cfg

data/last_notified.cfg

stem

gmail_pw

consensus_health_checker.py

+0 −17
Original line number Diff line number Diff line
@@ -776,23 +776,6 @@ def _get_documents(label, resource): 
      documents[authority.nickname] = query.run()[0]

      times_taken[authority.nickname] = time.time() - start_time

    except Exception as exc:

      if label == 'vote':

        # try to download the vote via the other authorities



        v3ident = DIRECTORY_AUTHORITIES[authority.nickname].v3ident



        query = downloader.query(

          '/tor/status-vote/current/%s.z' % v3ident,

          default_params = False,

          validate = True,

        )



        query.run(True)



        if not query.error:

          documents[authority.nickname] = list(query)[0]

          continue



      issues.append(Issue(Runlevel.ERROR, 'AUTHORITY_UNAVAILABLE', fetch_type = label, authority = authority.nickname, url = query.download_url, error = exc, to = [authority.nickname]))



  if label == 'consensus':