Skip to content

`unmeasured`, `vote` (and `consensus_bandwidth_is_unmeasured`) keywords are not properly treated

Have a look at the following 2 bw lines and there representation in our DB:

./16/2023-12-16-12-38-04-bandwidth-95BC922FA3DB2DDFC7E98ED4A9FFD0138A17BB1DEAD638852C601E55BD5878CF:bw=1 error_circ=5 error_destination=0 error_misc=0 error_second_relay=0 error_stream=0 master_key_ed25519=8VJa1wrFEuyszRnbE9z3D7acLWLvMrRgqodyrZzF1XM nick=TORPi node_id=FFDC0E2EA1D56C555978920C6D26EBA6AFF248FE relay_in_recent_consensus_count=103 relay_recent_measurement_attempt_count=5 relay_recent_measurements_excluded_error_count=5 relay_recent_priority_list_count=5 success=0 time=2023-12-16T00:41:02 unmeasured=1 vote=0 xoff_recv=0 xoff_sent=0

                   digest                  | bw | bw_mean | bw_median | consensus_bandwidth | consensus_bandwidth_is_unmeasured | desc_bw_avg | desc_bw_bur | desc_bw_obs_last | desc_bw_obs_mean | error_circ | error_destination | error_misc | error_second_relay | error_stream |             master_key_ed25519              | nick  |                 node_id                  | rtt | relay_in_recent_consensus_count | relay_recent_measurement_attempt_count | relay_recent_measurements_excluded_error_count | relay_recent_measurement_failure_count | relay_recent_measurements_excluded_near_count | relay_recent_measurements_excluded_old_count | relay_recent_measurements_excluded_few_count | relay_recent_priority_list_count | under_min_report | unmeasured | vote | xoff_recv | xoff_sent | success |        time         |               bandwidth_file                | r_strm | r_strm_filt 
---------------------------------------------+----+---------+-----------+---------------------+-----------------------------------+-------------+-------------+------------------+------------------+------------+-------------------+------------+--------------------+--------------+---------------------------------------------+-------+------------------------------------------+-----+---------------------------------+----------------------------------------+------------------------------------------------+----------------------------------------+-----------------------------------------------+----------------------------------------------+----------------------------------------------+----------------------------------+------------------+------------+------+-----------+-----------+---------+---------------------+---------------------------------------------+--------+-------------
 ehnR7l7BXiy24GF9TaeNYXjZBzWPCYff0VmoLRJL22I |  1 |      -1 |        -1 |                  -1 | f                                 |          -1 |          -1 |               -1 |               -1 |          5 |                 0 |          0 |                  0 |            0 | 8VJa1wrFEuyszRnbE9z3D7acLWLvMrRgqodyrZzF1XM | TORPi | FFDC0E2EA1D56C555978920C6D26EBA6AFF248FE |   0 |                             103 |                                      5 |                                              5 |                                      0 |                                             0 |                                            0 |                                            0 |                                5 | f                | f          | f    |         0 |         0 |       0 | 2023-12-16 00:41:02 | lbySL6PbLd/H6Y7Uqf/QE4oXux3q1jiFLGAeVb1YeM8 | 0     | 0 

and

./16/2023-12-16-12-36-10-bandwidth-8AB15BA0804A1CB8B8D251523118156C49107E7DA4B1888965B196365A309864:bw=33000 bw_mean=1157384 bw_median=991611 consensus_bandwidth=34000000 consensus_bandwidth_is_unmeasured=False desc_bw_avg=1073741824 desc_bw_bur=1073741824 desc_bw_obs_last=25973760 desc_bw_obs_mean=30132316 error_circ=0 error_destination=0 error_misc=0 error_second_relay=0 error_stream=0 master_key_ed25519=zak6whupYxRKeYPtIfYJBlQrksWKIVeUYXuyc+WZBM4 nick=Najdorf node_id=$FAF0A8829E39063669FA609B904E0FB8D5E1F23F relay_in_recent_consensus_count=120 relay_recent_measurement_attempt_count=15 relay_recent_priority_list_count=15 success=15 time=2023-12-16T07:41:31

                   digest                    |  bw   | bw_mean | bw_median | consensus_bandwidth | consensus_bandwidth_is_unmeasured | desc_bw_avg | desc_bw_bur | desc_bw_obs_last | desc_bw_obs_mean | error_circ | error_destination | error_misc | error_second_relay | error_stream |             master_key_ed25519              |  nick   |                  node_id                  | rtt | relay_in_recent_consensus_count | relay_recent_measurement_attempt_count | relay_recent_measurements_excluded_error_count | relay_recent_measurement_failure_count | relay_recent_measurements_excluded_near_count | relay_recent_measurements_excluded_old_count | relay_recent_measurements_excluded_few_count | relay_recent_priority_list_count | under_min_report | unmeasured | vote | xoff_recv | xoff_sent | success |        time         |               bandwidth_file                | r_strm | r_strm_filt 
---------------------------------------------+-------+---------+-----------+---------------------+-----------------------------------+-------------+-------------+------------------+------------------+------------+-------------------+------------+--------------------+--------------+---------------------------------------------+---------+-------------------------------------------+-----+---------------------------------+----------------------------------------+------------------------------------------------+----------------------------------------+-----------------------------------------------+----------------------------------------------+----------------------------------------------+----------------------------------+------------------+------------+------+-----------+-----------+---------+---------------------+---------------------------------------------+--------+-------------
 NzLgVvhWGgCgxBAaWw/XgeLQxHe3JT1OcZ2ChZWBHSU | 33000 | 1157384 |    991611 |            34000000 | f                                 |  1073741824 |  1073741824 |         25973760 |         30132316 |          0 |                 0 |          0 |                  0 |            0 | zak6whupYxRKeYPtIfYJBlQrksWKIVeUYXuyc+WZBM4 | Najdorf | $FAF0A8829E39063669FA609B904E0FB8D5E1F23F |   0 |                             120 |                                     15 |                                              0 |                                      0 |                                             0 |                                            0 |                                            0 |                               15 | f                | f          | f    |         0 |         0 |      15 | 2023-12-16 07:41:31 | irFboIBKHLi40lFSMRgVbEkQfn2ksYiJZbGWNlowmGQ |      0 |           0

The first one has unmeasured=1 and vote=0 while the latter has both of them missing. Yet in the DB both entries are f.

I guess in the first case the unmeasured should be t and vote should be f and in the second one it should be f and t, respectively?

/cc @juga