tpf parsing drops trailing newline

When descriptors are read from a file the trailing newline should be preserved (which is the case for all types except tpf desc.).

The raw-byte dump of TorperfResult drops the newlines at the end.

Setting to high-prio b/c this blocks legacy/trac#21759 (moved).

changed milestone to %metrics-lib 2.1.0 in legacy/trac

added component::metrics/library in Legacy / Trac milestone::metrics-lib 2.1.0 in Legacy / Trac owner::iwakeh in Legacy / Trac priority::high in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac labels

Like this?

Trac:
Status: new to needs_review

That looks fine! Thanks for the quick fix!

I'll apply this to legacy/trac#21759 (moved) and once that works, set this ticket to merge-ready.

What about a test for that and the other trailing newlines?

The fix works fine for legacy/trac#21759 (moved); test still welcome.

Like this?

Looks fine for the TorperfResult case, but shouldn't all descriptors end in newline? If yes, the test could be run for several input data (parametrized test). If no, there should be different tests and data for the various cases.

I think it's okay to assume that all descriptors should end in newline. Would you want to add a parameterized test?

Replying to karsten:

I think it's okay to assume that all descriptors should end in newline. Would you want to add a parameterized test?

Yup, I can do that. Setting to accepted.

Trac:
Status: needs_review to accepted
Owner: metrics-team to iwakeh

Please review the branch with tests.

The tests verify most of the Descriptor methods and stay implementation independent.

The fix&tests could be released this week as preparation of CollecTor 1.3.0 (cf. legacy/trac#21759 (moved)).

Trac:
Status: accepted to needs_review

Trac:
Milestone: N/A to metrics-lib 2.1.0

Merged with a tiny one-line tweak to the test data. Closing. Thanks!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved from legacy/trac#22912 (moved)

added Bug label and removed 1 deleted label

removed 1 deleted label