consensus-health message for ‘conflicting or invalid consensus parameters’ is unclear

2012-09-20 20:02:14 <nsa> ^Bor^B: [consensus-health] NOTICE: The following directory authorities set conflicting or invalid consensus parameters: maatuska CircuitPriorityHalflifeMsec=30000 UseOptimisticData=1 bwauthpid=1, moria1 CircuitPriorityHalflifeMsec=30000 UseOptimisticData=1 bwauthpid=1, turtles CircuitPriorityHalflifeMsec=30000 UseOptimisticData=1 bwauthpid=1

In this message, the consensus health checker is complaining because it thinks the ‘UseOptimisticData’ parameter is invalid.

This type of message should be split into two messages:

• one for an ‘invalid’ parameter (usually what this actually means is that consensus-health hasn't been told that a new parameter is valid yet), and
• one for an actual conflict between parameter values (in which case, it should show the name of the parameter with conflicting values, the values specified by each dirauth which votes on it, and the value produced in the consensus).