Drop file size parameter on Timeouts and failures of downloading files over Tor graph page
We recently switched from downloading three different file sizes (50 KiB, 1 MiB, 5 MiB) to downloading just one file size (5 MiB). As a result, the Timeouts and failures of downloading files over Tor graph is soon going to be blank for parameters 50 KiB or 1 MiB and only display dots for 5 MiB downloads.
There are several ways to deal with this:
- We could change the default parameter value to 5 MiB.
- We could redefine timeouts for smaller downloads, regenerate them, and analyze whether they have the same distribution.
- We could drop the file size parameter and display all timeouts and failures together.
We briefly discussed this at the last team meeting, when I suggested the first option and @djackson suggested the second option. But I think the third option would be the simplest and be likewise appropriate. Recall that OnionPerf's timeouts only exist to avoid overlapping measurements, not to model realistic timeouts in the sense of a user giving up on a request.
Thoughts on going for option three?