Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
S
sbws
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 121
    • Issues 121
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Network Health
  • sbws
  • Issues
  • #28712

Closed
Open
Opened Dec 04, 2018 by teor@teor

Make conf['tor']['extra_lines'] into a torrc file

sbws tries to parse extra torrc options from its config file, and add them to the existing options. But this code is buggy: it tries to merge extra options with existing options with the same name. That doesn't work if the option is only allowed to occur once in the torrc file.

Tor can get options from these places, in this order:

  • torrc-defaults file
  • torrc file
  • command-line (stem's launch command)
  • control port (stem's control port command)

Here's a better design for sbws:

  • hard-coded options in a torrc-defaults file
  • extra user options in a torrc file
  • configured options on the command-line
  • runtime options over the control port

This means that:

  • users can override hard-coded options using the torrc file
  • users can modify configured options using the sbws config.ini
  • users can't modify runtime options (for simplicity)
Assignee
Assign to
sbws: unspecified
Milestone
sbws: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: tpo/network-health/sbws#28712