Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S sbws
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Network Health
  • sbws
  • Issues
  • #28736
Closed
Open
Issue created Dec 05, 2018 by juga@jugaMaintainer

Make info level logs more clear and consistent

I think the operator should see, at info level:

  • see one line when it fails (with the nick/fp of both relays and the reason)
  • see one line when it doesn't (with the nick/fp of both relays) Currently the failures are logged at several po ints in the code (and several levels) and the messages don't provide the same available information

For instance, every time a relay fails to be measured, all these lines are shown:

2018-12-05 12:35:12,104 WARNING Thread-5 circuitbuilder.py:83 - _build_circuit_impl - Circuit failed to be created: CHANNEL_CLOSED
2018-12-05 12:35:12,107 WARNING Thread-5 circuitbuilder.py:83 - _build_circuit_impl - EXTENDCIRCUIT returned unexpected response code: 551
2018-12-05 12:35:12,108 WARNING Thread-5 circuitbuilder.py:83 - _build_circuit_impl - EXTENDCIRCUIT returned unexpected response code: 551
2018-12-05 12:35:12,109 WARNING Thread-5 scanner.py:203 - measure_relay - Could not build circuit involving UbuntuCore250
2018-12-05 12:36:13,848 WARNING Thread-5 scanner.py:217 - measure_relay - When measuring default 565B07B9 the destination seemed to have stopped )

I think this should be only 1 line a level INFO, and the rest at DEBUG level

For success measurements, it logs

2018-12-05 12:40:13,947 INFO Thread-1 resultdump.py:544 - handle_result - Torrr 96EA4E2C finished measurement with ResultSuccess

Instead of ResultSuccess, should say which two relays were measured.

Edit: format

Assignee
Assign to
Time tracking