Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S sbws
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Network Health
  • sbws
  • Issues
  • #28870
Closed
Open
Issue created Dec 17, 2018 by juga@jugaMaintainer

Stop asserting when there's not a descriptor for a relay being measured

When sbws doesn't have a descriptor for a relay that is being measured (but it has a network status document, and possibly the other way around), it raises and exception via this assert (https://github.com/torproject/sbws/blob/ee64d76df54ceb3a3c9e1e2a797fd70d68bb0035/sbws/lib/relaylist.py#L45), which causes the error callback in the thread pool in scanner. Instead, it should just return None (what can also be done by getattr and removes redundant code), and all the logic that depends on it will just work fine, it just won't be choose as an exit, since there's no information about the exit flags, but will get measured.

Assignee
Assign to
Time tracking