Make sbws vote for all measured relays, even if they are not Running / not in the consensus

I think the answer is probably "yes, but other tickets are more important right now".

changed milestone to %sbws: 1.1.x-final in legacy/trac

Trac:
Parent Ticket: legacy/trac#33121 (moved)

added component::core tor/sbws in Legacy / Trac milestone::sbws: 1.1.x-final in Legacy / Trac must-keep-3-torflow-blocker in Legacy / Trac owner::juga in Legacy / Trac parent::33121 in Legacy / Trac priority::very high in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::ahf in Legacy / Trac sbws-majority-blocker in Legacy / Trac sbws-roadmap in Legacy / Trac severity::critical in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac version::sbws 1.1.0 in Legacy / Trac labels

Until we do this fix, we need to keep at least 3 torflow instances in the network.

For more details, see: https://trac.torproject.org/projects/tor/ticket/29710#comment:16

We also need to do this fix because authorities and clients can have different views of the Running relays.

Trac:
Version: sbws: unspecified to sbws: 1.1.0
Severity: Major to Critical
Summary: Should sbws vote for relays that aren't Running? to Make sbws vote for all measured relays, even if they are not Running
Milestone: sbws: unspecified to sbws: 1.1.x-final
Priority: High to Very High

Trac:
Keywords: N/A deleted, sbws-majority-blocker, must-keep-3-torflow-blocker added

I found more relevant information in https://trac.torproject.org/projects/tor/ticket/29710?replyto=13#comment:

sbws only reports bandwidths for Running relays, but torflow reports bandwidths for all relays it has recently measured.

So, is torflow reporting bandwidth for all the relays seen in the last 5 days even if they were not in the consensus?. What about the relays for which there's no descriptors?, just use the last descriptor seen?.

Replying to juga:

I found more relevant information in https://trac.torproject.org/projects/tor/ticket/29710?replyto=13#comment:

sbws only reports bandwidths for Running relays, but torflow reports bandwidths for all relays it has recently measured.

So, is torflow reporting bandwidth for all the relays seen in the last 5 days even if they were not in the consensus?

Yes.

What about the relays for which there's no descriptors?, just use the last descriptor seen?.

Why is sbws missing the descriptors for some relays? The authorities and directory mirrors should have them? See bug legacy/trac#30733 (moved).

But yes, if we can't get the descriptor in the consensus (or if the relay is not in the consensus), just use the most recent descriptor data we have.

Trac:
Summary: Make sbws vote for all measured relays, even if they are not Running to Make sbws vote for all measured relays, even if they are not Running / not in the consensus

Juga says they have some unpublished work on this ticket.

Trac:
Owner: N/A to juga
Status: new to assigned

Trac:
Status: assigned to needs_review

See https://github.com/torproject/sbws/pull/361

Trac:
Reviewer: N/A to ahf

Trac:
Keywords: N/A deleted, sbws-roadmap added

Added a few minor nitpicks and also I think there is a missing return statement, but all-in-all it looks good.

Trac:
Status: needs_review to needs_revision

Thanks, i think i addressed what you commented.

Trac:
Status: needs_revision to needs_review

Looks good!

Trac:
Status: needs_review to merge_ready

The goal is to deploy sbws in all bw authorities. We need to fix critical bugs to do this.

Trac:
Parent: legacy/trac#29710 (moved) to legacy/trac#33121 (moved)

Merged!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

mentioned in issue legacy/trac#30735 (moved)

mentioned in issue legacy/trac#33199 (moved)