GitLab

I saw this too late after the MR got finally reviewed and merged but !19 (merged) breaks our integration tests:

=================================== FAILURES
===================================
________________________________ test_v3bwfile
_________________________________

conf = <configparser.ConfigParser object at 0x7fbc5d8bdcf8>

    def test_v3bwfile(conf):
        bwfile = V3BWFile.from_v1_fpath(
>           conf["paths"]["v3bw_fname"].format("latest")
        )

tests/integration/test_files.py:40:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _
sbws/lib/v3bwfile.py:1109: in from_v1_fpath
    bw_lines = [V3BWLine.from_bw_line_v1(line) for line in lines]
sbws/lib/v3bwfile.py:1109: in <listcomp>
    bw_lines = [V3BWLine.from_bw_line_v1(line) for line in lines]
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _

cls = <class 'sbws.lib.v3bwfile.V3BWLine'>
line = 'bw=1 bw_mean=5599261 bw_median=5627934 consensus_bandwidth=0
consensus_bandwidth_is_unmeasured=False
desc_bw_avg=1073...rement_attempt_count=1
relay_recent_priority_list_count=1 success=1 time=2020-07-21T10:52:45
under_min_report=1 vote=0'

    @classmethod
    def from_bw_line_v1(cls, line):
        assert isinstance(line, str)
        kwargs = dict([kv.split(KEYVALUE_SEP_V1)
                       for kv in line.split(BWLINE_KEYVALUES_SEP_V1)
                       if kv.split(KEYVALUE_SEP_V1)[0] in BWLINE_KEYS_V1])
        for k, v in kwargs.items():
            if k in BWLINE_INT_KEYS:
>               kwargs[k] = int(v)
E               ValueError: invalid literal for int() with base 10: 'False'

sbws/lib/v3bwfile.py:834: ValueError