status-site issueshttps://gitlab.torproject.org/tpo/tpa/status-site/-/issues2023-11-16T10:37:19Zhttps://gitlab.torproject.org/tpo/tpa/status-site/-/issues/37merge "experiment" support upstream2023-11-16T10:37:19Zanarcatmerge "experiment" support upstreamit would be nice if some of our most important divergences were merged upstream.
right now, we have this:
```
anarcat@angela:status.torproject.org$ find layouts/ -type f
layouts/README.md
layouts/partials/custom/meta.html
layouts/part...it would be nice if some of our most important divergences were merged upstream.
right now, we have this:
```
anarcat@angela:status.torproject.org$ find layouts/ -type f
layouts/README.md
layouts/partials/custom/meta.html
layouts/partials/index/noscript.html
layouts/partials/index/components.html
layouts/experiments/small.html
layouts/experiments/single.html
layouts/experiments/single.json
layouts/experiments/experiment.html
```
out of those:
* `layout/experiments/*` doesn't actually override anything upstream: it's all new, so that's relatively safe
* `meta.html` is an expected override (upstream is just a commented out example)
* `noscript.html` is an expected override: we silence the upstream warning about noscript... we *could* upstream this as a toggle, but it seems overkill
* `layouts/partials/index/components.html`, on the other hand, is quite a diff
In !46, I actually tried to merge that file with the latest upstream, to fix broken links in review apps (#36)... the merge wasn't quite trivial, but more importantly, it wasn't obvious we even *had* to merge something in there.
It would be nice to consider upstreaming our changes here. We could find a way to patch the upstream repo to add support for experiments. I think that would involve sending a PR upstream, alongside some docs fixes to document the feature.
What do you think, @gk? Is that something you think could be done?https://gitlab.torproject.org/tpo/tpa/status-site/-/issues/12make resolved/resolvedWhen useful for experiments2023-11-09T22:50:07Zanarcatmake resolved/resolvedWhen useful for experimentsin !12, I noticed that we can't quite change the severity of an experiment or mark it as resolved as we typically do with other issues.
it would be nice if we could use the same workflow than other issues. in !12, for example, it would ...in !12, I noticed that we can't quite change the severity of an experiment or mark it as resolved as we typically do with other issues.
it would be nice if we could use the same workflow than other issues. in !12, for example, it would this part irrelevant:
```diff
## When did it stop?
-Not yet, it's still ongoing as far as we know.
+Around 2021-09-08 13:00:00 UTC.
```
which would be less error-prone.