Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • TPA team TPA team
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 174
    • Issues 174
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • TPA
  • TPA teamTPA team
  • Issues
  • #4553

Closed
Open
Created Nov 24, 2011 by Nick Mathewson@nickm🏃

Let's have a new ticket status: needs_revision?

Right now, needs_review means one of two things: either a ticket that actually needs code review of some kind, or a ticket that has received code review and is waiting for somebody to revise the code.

This makes it harder for me to figure out which tickets I actually need to review, which ones I need to bug somebody to finish up, and so on. It also sometimes makes people think that their code is waiting on me for review, when it is actually waiting on them to fix up.

(Why not just re-assign the ticket back to them, and remove it from needs_review? Because I find that it's really important to keep tickets with fixable code separate, so I can remember to bug the people to finish up the code, and so I can jump in and do the final cleanups if the aren't to big and the person who did the first version can't finish the patch.)

This should probably get a little discussion before anybody goes and implements it; I don't know whether anybody but me thinks it's a great idea. But I do think that it's a great idea!

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking