diff --git a/howto/gitlab.md b/howto/gitlab.md index 33f1a4859c6dbceef4673b1a2a4a931a38b13ced..9bc72364408f128dacdf81d4e4ecad4ebfa5a6db 100644 --- a/howto/gitlab.md +++ b/howto/gitlab.md @@ -76,9 +76,7 @@ clear text as well, although at the time of writing all projects are correctly configured. The IRC side of things, of course, might also leak information. -Note that internal notes are currently *not* being redacted, because -of a limitation in how GitLab fails to add a special header for those -outgoing emails, see [issue 145](https://gitlab.torproject.org/tpo/tpa/gitlab/-/issues/145). +Note that internal notes are currently *not* being redacted, unless they are added to confidential issues, see [issue 145](https://gitlab.torproject.org/tpo/tpa/gitlab/-/issues/145). ## How to contribute code? @@ -1521,8 +1519,7 @@ GitLab 16.2 for the GitLab application side. Those add a header like: X-GitLab-ConfidentialIssue: true -To outgoing email when a confidential issue is created or commented -on, or when an "internal note" is added. +To outgoing email when a confidential issue is created or commented on. Note that internal notes are currently *not* being redacted, unless they are added to confidential issues, see [issue 145](https://gitlab.torproject.org/tpo/tpa/gitlab/-/issues/145). That header, in turn, is parsed by the outgoing Postfix server to redact those emails. This is done through a [header_checks(5)](https://www.postfix.org/header_checks.5.html) in