@@ -76,9 +76,7 @@ clear text as well, although at the time of writing all projects are
correctly configured. The IRC side of things, of course, might also
correctly configured. The IRC side of things, of course, might also
leak information.
leak information.
Note that internal notes are currently *not* being redacted, because
Note that internal notes are currently *not* being redacted, unless they are added to confidential issues, see [issue 145](https://gitlab.torproject.org/tpo/tpa/gitlab/-/issues/145).
of a limitation in how GitLab fails to add a special header for those
outgoing emails, see [issue 145](https://gitlab.torproject.org/tpo/tpa/gitlab/-/issues/145).
## How to contribute code?
## How to contribute code?
@@ -1521,8 +1519,7 @@ GitLab 16.2 for the GitLab application side. Those add a header like:
X-GitLab-ConfidentialIssue: true
X-GitLab-ConfidentialIssue: true
To outgoing email when a confidential issue is created or commented
To outgoing email when a confidential issue is created or commented on. Note that internal notes are currently *not* being redacted, unless they are added to confidential issues, see [issue 145](https://gitlab.torproject.org/tpo/tpa/gitlab/-/issues/145).
on, or when an "internal note" is added.
That header, in turn, is parsed by the outgoing Postfix server to
That header, in turn, is parsed by the outgoing Postfix server to
redact those emails. This is done through a [header_checks(5)](https://www.postfix.org/header_checks.5.html) in
redact those emails. This is done through a [header_checks(5)](https://www.postfix.org/header_checks.5.html) in
