Verified Commit c2547aee authored by anarcat's avatar anarcat
Browse files

we do *not* actually have another job on each host 

I'm not sure where that comment came from: I looked in the tor-nagios
history and couldn't find a trace of that plugin.

We might set it up eventually though, as part of team#40706.
parent 7e897ee1

howto/puppet.md

+7 −4
Original line number Diff line number Diff line
@@ -1556,10 +1556,13 @@ Puppet is hooked into Nagios in two ways: 
   reports. this was done with a [patched](https://github.com/evgeni/check_puppetdb_nodes/pull/14) version of the

   [check_puppetdb_nodes](https://github.com/evgeni/check_puppetdb_nodes/) Nagios check, now packaged inside the

   `tor-nagios-checks` Debian package

 * another job runs on each Puppet node and will therefore work even

   if the Puppetmaster dies for some reason. this is done with the

   [check_puppet_agent](https://github.com/aswen/nagios-plugins/blob/master/check_puppet_agent) Nagios check, now also packaged inside the

   `tor-nagios-checks` Debian package

 * the same job actually runs twice; once to check all manifests, and

   another to check each host individually and assign the result to

   the right how



The twin checks are present so that we can find stray Puppet hosts,

for example if a host was retired from Nagios but not retired from

Puppet, or added to Nagios but not Puppet.



This was [implemented in March 2019](https://gitlab.torproject.org/tpo/tpa/team/-/issues/29676). An alternative implementation

[using Prometheus](https://forge.puppet.com/puppet/prometheus_reporter) was considered but [Prometheus still hasn't