log IP addresses for failed transactions
In #117 (and before that, in #114), we identified that we need to log IP addresses when we have failed transactions, so we can handle abuse correctly. In !135 (merged), we redacted a lot of PII, including IP addresses, but even there the IP address we were logging weren't the ones from the clients.
So we need to somehow report that in our logs, so we can handle abusers correctly. In !139 (merged), I identified two possible paths for this:
- fetch the IP address from the payment controller's view, hopefully present in the webhook payload
- keep track of the IP address on our side (in redis?) and log/destroy it when we get the webhook back
We also need to decide whether we log IP addresses for failures or all transactions, i would favor the former.
Edited by anarcat