GitLab

In order to let us use fetch with credentials (to send cookies), the
allowed origin needs to match the URL for the site using fetch. So if
the request is coming from an onion URL, then assume it's from the onion
donate site.

Contributions beyond $100k in the campaign period are not matched, so
this limits the doubling logic to the appropriate amount and supplies
the correct amount in the JSON used by the donate page counter.

Issue #49798

This reverts commit 9a7940ba.

This didn't work because then we get this error in the browser:

Access to fetch at
'https://donate-api.torproject.org/setExpressCheckout' from origin
'https://donate.torproject.org' has been blocked by CORS policy:
Response to preflight request doesn't pass access control check: The
value of the 'Access-Control-Allow-Origin' header in the response must
not be the wildcard '*' when the request's credentials mode is
'include'.

The newsletter site captcha isn't working because it needs this header
set to newsletter.torproject.org and this header doesn't allow multiple
origins. We'll just set it to wildcard for now and figure out if we can
do something else.

Tor has Referrer-Policy: no-referrer on their live server, so we can't
use the referrer for going back to the page that sent the request.

Forgot to checkin a file.

reset takes a reference, so we can't just pass the result of a function.

Issue #48283

Part of porting the site to lektor site, cryptocurrency page
is going to be on the lektor site. To allow flexibility of
where people are going to be redirected after the submission,
this code is put into place. key pair 'cryptocurrencyThankyouUrl'
=> '/cryptocurrency/thank-you' needs to be added in $localOptions
in private/settings.local.php on the donate server for local
settings.

Issue #48280

If a user clicks on a link like an optout or unsubscribe link in a
CiviCRM mailing and then there's some issue with the unsubscribe, we
need to show them some errors, so we need to send them back to the
lektor site because we aren't going to have any display pages on the
donate site once the Lektor pages go live.

Issue #48285

This lets Lektor handle the subscription forms and get back error
messages and get redirected back to the correct pages.

Issue #48283

With moving the form to a different website we need to have some
Access-Control headers set or the browser will block fetch requests.
Slim doesn't apply the middleware when it's handling the response
object for errors, so the middleware wasn't adding these headers so the
browser was blocking the error results.

The PHP errors are handled with a separate error handler so I had to
repeat everything for those as well so that PHP errors will also get
handled correctly.

Issue #48541

Chrome defaults to not sharing cookies across site unless you set
SameSite=None and you also need to set Secure and HttpOnly or it won't
let you set SameSite=None.

Issue #47134

Stephanie Kirtiadi authored Jun 24, 2020 and peterh-gr committed Sep 11, 2020

Issue #45530

Stephanie Kirtiadi authored Jun 19, 2020 and peterh-gr committed Sep 11, 2020

Added a section in README to add the Tor lektor site base url.

Issue #45530

Client requested removal of the Monero wallet address, which
will be updated later.

Issue #48192

Some of the countries and regions changed with the latest Civi update.

Reduced the timespan for subscriptions from a single IP address to 1
hour. This increases the amount of subscriptions per IP address to 10
per hour instead of 10 per 6 hours. We get a lot of subscription
requests from specific Tor exit points and we think those are
legitimate, so we don't want to block them.

Issue #47628

We don't really care if they pound the page with incorrect captcha or other
fields, so let's only check the IP rate limit if they fill out the fields
correctly. That way we don't get as many errors emailed to us.

We've been getting what we think is a lot of spam from one of the Tor exit
nodes, so we want to try a captcha on the subscription page to see if it calms
down.

Issue #46281

We're getting a ton of subscription request errors from the rate limiter
and they seem to be coming from a Tor exit node. I'm curious to see how
many of these are getting confirmed to get some idea about whether these
are legitimate requests or not.

The campaign is over for this year, so we can shut off the constant
campaign totals fetching. They complained last year when I didn't shut
it off.

We're actually getting results that indicate someone is sending lots of
requests to the /subscription-request thing. I want to print out more
details in the log to see if we can get an idea if this is legitimate
traffic or not.

Issue #44700

If you started the rate limiter for an IP address and then let it sit
for awhile, you could get the $allowance to build up over the rate
limit for a small amount of time.

Issue #44827

An attacker could use the /subscribe form to send tons of emails to
anyone's email address. We want to limit that so it doesn't cause
problem. This limits it to 10 emails per 6 hours. It's actually doing it
by rate, so once you hit the limit of 10, then you can send another one
about 36 minutes after that and keep sending one every 36 minutes.

Issue #44700

We need to be able to get the IP address for the request. I wanted to
use a library so that we can handle the case where the app gets moved
behind a proxy. Right now the ip-address-middleware is configured to
ignore the proxy (X-Forwarded-For) addresses because client can spoof
those, but if we do put it behind a proxy then we can trust the header
(assuming the proxy is configured correctly) and we just need to change
the arguments to the constructor in src/middleware.php to adjust for the
proxy.

Sarah asked to have us turn off the counters immediately, so I'm just
setting it to this time which just passed.

Eastern.

We have confirmation that the desired end time of the matching campaign
is end of day Dec 31 2019 in Pacific Time, not the current Eastern
US Time.

Issue #43359

Compliance company's original instructions for the Georgia state
disclosure were ambiguous about whose contact information ought to be
displayed. Client requested an update after clarifying.

Reversal of the 44008 ticket change.

Issue #44054

This widget was added on the page on Sarah's request to be
taken down today.

Issue #44054

Sarah asked us to put this iframe on the cryptocurrency page.

Issue #44008

Issue #43939

Minimum donation to be reported is $20k from $5k. The State
Disclosures for Georgia phone number is now included.

Issue #43939

Some of these unicode characters make the translation script spit out
warnings. We can use these alternatives.

Before the counter starts with 1 to create dynamic effect,
but currently the background of the counter has changed,
leaving the 1 very visible. We're changing these 0 to 1.

Issue #43959

Issue #43939

The green color for resolved character is bright, and so is the
unresolved color. Now the unresolved cahracter color is dark.

Issue #43959

The client would like a revision to the FAQ page and a new
page for the state registration disclosures.

Issue #43939