forward-port the 0.4.8.12 changes

See merge request !834

excurso authored 6 months ago and David Goulet committed 6 months ago

Resources allocated by cpuworker weren't being freed on clean shutdown.
This applies for worker threads, worker thread pool, reply queue, reply
event, ...

Signed-off-by: David Goulet <dgoulet@torproject.org>

Handle empty DNS reply without error as NOERROR

Closes #40248

See merge request !830

Fix unit test in test_entrynodes.c

See merge request !831

Fix a typo in the HTTP proxy error message.

See merge request tpo/core/tor!829

Signed-off-by: David Goulet <dgoulet@torproject.org>

This proposal adds new syntax to the SOCKS5 username/password extension scheme,
so that requests with usernames starting with <torS0X> are now reserved.

For C tor, all we need to do is reject every username starting with <torS0X>
unless it is exactly "<torS0X>0".

Fixes #40966

Signed-off-by: David Goulet <dgoulet@torproject.org>

two small presentation issues in man page

See merge request tpo/core/tor!824

Implement phase 1 of Proposal 350 (remove TAP onion keys)

See merge request tpo/core/tor!822

Relay=1 is no longer supported; it corresponds to TAP.

Microdesc=3 and Desc=3 are now supported; they correspond to the ability to
handle (micro)descriptors without TAP onion keys.

All of these elements are now mandatory, so we can now simplify
our logic for making sure that they are all present or all not-present.

(Renaming them has forced me to look at every place where they are used, so I
can make sure that they are really optional now.)

Also, stop storing onion keys in microdesc_t.

(In prop350, for microdescs, we are making the body optional; the "onion-key"
entry is still mandatory, so that we can tell where microdescs begin.)

Signed-off-by: David Goulet <dgoulet@torproject.org>

Alexander Hansen Færøy authored 1 year ago and David Goulet committed 9 months ago

This patch makes sure we clean up our version and implementation fields
in our Managed Proxy struct after each test run.

This was detected by LeakSanitizer.

See: tpo/core/tor#11101.

Alexander Hansen Færøy authored 1 year ago and David Goulet committed 9 months ago

This patch adds two new keys to bridges' extra-info document:
"transport-version" and "transport-implementation".

These two new values always appear together (if one is missing, the
other one will be missing too) and is parsed from PT's STATUS
TYPE=version messages.

See: tpo/core/tor#11101.