Skip to content
Snippets Groups Projects
  1. Aug 01, 2022
  2. Jul 22, 2022
  3. May 27, 2022
  4. May 24, 2022
  5. May 20, 2022
  6. May 18, 2022
  7. May 13, 2022
  8. May 12, 2022
  9. May 11, 2022
  10. May 09, 2022
  11. May 06, 2022
  12. May 05, 2022
  13. May 04, 2022
  14. Apr 27, 2022
  15. Apr 26, 2022
  16. Apr 25, 2022
  17. Apr 22, 2022
    • Ian Jackson's avatar
      logfiles: Introduce LogfileListConfigBuilder · 79decd4a
      Ian Jackson authored
      In
        tpo/core/arti!462 (comment 2797697)
      we decided not to do this.
      
      However, having looked again at the way the FallbackList works, I
      think there is a lot of value in making these two things (and anything
      else like them[1]) as similar as possible.
      
      [1] At least PreemptiveCircuitConfig.initial_predicted_ports and
      NetworkConfig.authorities need the same treatment, and perhaps also
      GuardUsage.restrictions (although there is no
      GuardRestrictionBuilder).
      
      In the irc discussion I imagined `LogfilesConfigBuilder` as opposed to
      `LogfileConfigBuilder` (differing only in the `s`) which would be bad,
      but we can use `List` instead.
      
      We do *not* need to abstract away the validated version of the config.
      Providing a type alias helps the derive_builder sub_builder DTRT
      without needing special overrides.
      
      I have split this commit so that we can drop it, if we conclude it's
      not wanted.
      79decd4a
Loading