Roger Dingledine authored 8 years ago and Nick Mathewson committed 8 years ago

pointed out by toralf on irc

David Goulet authored 8 years ago and Nick Mathewson committed 8 years ago

When marking for close a circuit, the reason value, a integer, was assigned to
a uint16_t converting any negative reasons (internal) to the wrong value. On
the HS side, this was causing the client to flag introduction points to be
unreachable as the internal reason was wrongfully converted to a positive
16bit value leading to flag 2 out of 3 intro points to be unreachable.

Fixes #20307 and partially fixes #21056

Signed-off-by: David Goulet <dgoulet@torproject.org>

(event_init() is obsoleted in libevent 2.)

Fixes bug 21051; bugfix on 0.2.9.1-alpha when we dropped libevent 1
support.

This came up on #21035, where somebody tried to build on a linux
system with kernel headers including CLOCK_MONOTONIC_COARSE, then
run on a kernel that didn't support it.

I've adopted a belt-and-suspenders approach here: we detect failures
at initialization time, and we also detect (loudly) failures later on.

Fixes bug 21035; bugfix on 0.2.9.1-alpha when we started using
monotonic time.

This helps protect against bugs where any part of a buf_t's memory
is passed to a function that expects a NUL-terminated input.

It also closes TROVE-2016-10-001 (aka bug 20384).

("ours" merge because there is a separate 20384 patch for 026)

This helps protect against bugs where any part of a buf_t's memory
is passed to a function that expects a NUL-terminated input.

(ours merge -- there is a separate 0.2.5 patch for 20384.)

This helps protect against bugs where any part of a buf_t's memory
is passed to a function that expects a NUL-terminated input.