1. 17 Dec, 2020 2 commits
  2. 16 Dec, 2020 4 commits
  3. 15 Dec, 2020 2 commits
  4. 14 Dec, 2020 1 commit
    • Nick Mathewson's avatar
      Socks5: handle truncated client requests correctly · c4fe66e3
      Nick Mathewson authored
      Previously, our code would send back an error if the socks5 request
      parser said anything but DONE.  But there are other non-error cases,
      like TRUNCATED: we shouldn't send back errors for them.
      
      This patch lowers the responsibility for setting the error message
      into the parsing code, since the actual type of the error message
      will depend on what problem was encountered.
      
      Fixes bug 40190; bugfix on 0.3.5.1-alpha.
      c4fe66e3
  5. 11 Dec, 2020 1 commit
    • David Goulet's avatar
      configure: Revert back the static libevent path · 15b0d30a
      David Goulet authored
      From c618c4f2
      
      , we changed the static
      libevent.a path to be able to use the git repository or tarball directly but
      that broke the "make install" setup that Tor Browser is using with Android.
      
      In other words, the git repository and tarball put the "libevent.a" in
      ".libs/" where "make install" puts it in "lib/".
      
      Using the --with-libevent-dir=..., which is mandatory for static libevent,
      autoconf will take the path and use it for the includes (-I) and library (-L)
      for which if it finds a "include/" and a "lib/" in the root, it will use
      those.
      
      However, with the git repo or tarball, the "lib/" doesn't exists thus autoconf
      sets the library search path to be at the root and thus fails to find the
      libevent.a in ".libs/".
      
      This is a whole lot more work to make both cases work in our configure.ac thus
      I'm reverting the change here to the Tor Browser case works again and the work
      around for others is to either symlink the libevent.a at the root or use a
      temporary make install directory.
      
      One long term fix here would likely be to ask libevent to symblink the .a into
      the root along the .la files and likely do the same for .so. Or, use the
      "lib/" structure to contain the .a + .so files. Would be better than doing
      ninji-tsu in our configure.ac
      
      Fixes #40225
      
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      15b0d30a
  6. 09 Dec, 2020 1 commit
  7. 08 Dec, 2020 4 commits
  8. 23 Nov, 2020 1 commit
  9. 21 Nov, 2020 1 commit
  10. 19 Nov, 2020 3 commits
  11. 18 Nov, 2020 2 commits
  12. 17 Nov, 2020 13 commits
  13. 13 Nov, 2020 1 commit
    • David Goulet's avatar
      port: Don't ignore ports of a different family · d425dbf0
      David Goulet authored
      Commit c3a0f757
      
       added this feature for ORPort
      that we ignore any port that is not the family of our default address when
      parsing the port. So if port_parse_config() was called with an IPv4 default
      address, all IPv6 address would be ignored.
      
      That makes sense for ORPort since we call twice port_parse_config() for
      0.0.0.0 and [::] but for the rest of the ports, it is not good since a
      perfectly valid configuration can be:
      
        SocksPort 9050
        SocksPort [::1]:9050
      
      Any non-ORPort only binds by default to an IPv4 except the ORPort that binds
      to both IPv4 and IPv6 by default.
      
      The fix here is to always parse all ports within port_parse_config() and then,
      specifically for ORPort, remove the duplicates or superseding ones. The
      warning is only emitted when a port supersedes another.
      
      A unit tests is added to make sure SocksPort of different family always exists
      together.
      
      Fixes #40183
      
      Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
      d425dbf0
  14. 12 Nov, 2020 4 commits