-
- Downloads
Bug 1657404 - Implement a strongly-typed, service-dependent gamepad handle r=handyman,aklotz
Currently, the gamepad code uses a uint32_t as a handle and does some trickery with it by trying to create a unique ID and adding an offset to it for VR code. This can (and has) led to errors where the developer forgets to perform the arithmetic and sends the wrong number to the wrong manager. This change created a strongly-typed handle that remembers which service it belongs to. This should eliminate such accidents. Differential Revision: https://phabricator.services.mozilla.com/D96273
Showing
- dom/base/nsGlobalWindowInner.cpp 10 additions, 7 deletionsdom/base/nsGlobalWindowInner.cpp
- dom/base/nsGlobalWindowInner.h 9 additions, 4 deletionsdom/base/nsGlobalWindowInner.h
- dom/gamepad/Gamepad.cpp 5 additions, 5 deletionsdom/gamepad/Gamepad.cpp
- dom/gamepad/Gamepad.h 5 additions, 4 deletionsdom/gamepad/Gamepad.h
- dom/gamepad/GamepadHandle.cpp 40 additions, 0 deletionsdom/gamepad/GamepadHandle.cpp
- dom/gamepad/GamepadHandle.h 89 additions, 0 deletionsdom/gamepad/GamepadHandle.h
- dom/gamepad/GamepadHapticActuator.cpp 4 additions, 4 deletionsdom/gamepad/GamepadHapticActuator.cpp
- dom/gamepad/GamepadHapticActuator.h 3 additions, 2 deletionsdom/gamepad/GamepadHapticActuator.h
- dom/gamepad/GamepadLightIndicator.cpp 5 additions, 4 deletionsdom/gamepad/GamepadLightIndicator.cpp
- dom/gamepad/GamepadLightIndicator.h 3 additions, 2 deletionsdom/gamepad/GamepadLightIndicator.h
- dom/gamepad/GamepadManager.cpp 68 additions, 103 deletionsdom/gamepad/GamepadManager.cpp
- dom/gamepad/GamepadManager.h 20 additions, 26 deletionsdom/gamepad/GamepadManager.h
- dom/gamepad/GamepadMonitoring.h 2 additions, 1 deletiondom/gamepad/GamepadMonitoring.h
- dom/gamepad/GamepadPlatformService.cpp 33 additions, 33 deletionsdom/gamepad/GamepadPlatformService.cpp
- dom/gamepad/GamepadPlatformService.h 31 additions, 27 deletionsdom/gamepad/GamepadPlatformService.h
- dom/gamepad/GamepadRemapping.cpp 221 additions, 221 deletionsdom/gamepad/GamepadRemapping.cpp
- dom/gamepad/GamepadRemapping.h 3 additions, 3 deletionsdom/gamepad/GamepadRemapping.h
- dom/gamepad/GamepadServiceTest.cpp 55 additions, 21 deletionsdom/gamepad/GamepadServiceTest.cpp
- dom/gamepad/GamepadServiceTest.h 15 additions, 9 deletionsdom/gamepad/GamepadServiceTest.h
- dom/gamepad/android/AndroidGamepad.cpp 34 additions, 13 deletionsdom/gamepad/android/AndroidGamepad.cpp
Loading
Please register or sign in to comment