- Oct 14, 2021
-
-
Agi Sferro authored
Differential Revision: https://phabricator.services.mozilla.com/D128405
-
stransky authored
mScheduledTask means scheduled task. When there's nothing sheduled we look inactive but that's not correct. Let's remove that check as it was before. Differential Revision: https://phabricator.services.mozilla.com/D128488
-
André Bargull authored
This is based on Tom's original patch in bug 725966. As the last optimisation in this stack, optimise typeof in simple comparison contexts. For example: ``` if (typeof thing === "number") { ... } ``` is now optimised into: ``` if (IsNumber(thing)) { ... } ``` This optimisation is only used when there's a single user of the `MTypeOfName` instruction to avoid slowing down the case when `typeof` is used in `switch` statements. For example consider: ``` switch (typeof thing) { case "object": case "undefined": case "number": case "boolean": case "string": case "symbol": case "bigint": case "function": } ``` If `thing` was a function, using the `MTypeOfIs` optimisation would mean that the type tag is split eight times (for each `case` statement), possibly even two OOL calls when the function is a proxy (for the "object" and "undefined" cases). Differential Revision: https://phabricator.services.mozilla.com/D128078
-
André Bargull authored
Add `testThingSet` methods in preparation for the next part. MIPS doesn't support `MacroAssembler::emitSet()`, so we have to introduce this additional abstraction. Differential Revision: https://phabricator.services.mozilla.com/D128077
-
André Bargull authored
This optimisation folds away string comparisons when `typeof` appears in equality comparison contexts: MTypeOfName(MTypeOf(input)) == MConstant(string) is now optimised to: MTypeOf(input) == MConstant(int32). Differential Revision: https://phabricator.services.mozilla.com/D128076
-
André Bargull authored
- `JSTYPE_UNDEFINED` is similar to `JSTYPE_OBJECT` and has to handle both undefined and objects inputs. - `JSTYPE_FUNCTION` can never occur when the input isn't an object. - `JSTYPE_LIMIT` means the string constant isn't a valid type name. Differential Revision: https://phabricator.services.mozilla.com/D128075
-
André Bargull authored
Moves the `typeof` equality comparison detection into a separate function, so we can reuse it in part 8. Additionally it was updated to handle all possible `JSType` constants. Differential Revision: https://phabricator.services.mozilla.com/D128074
-
André Bargull authored
Split `MTypeOf` in two separate instructions so it's easier to further optimise it in comparison contexts, see part 8. Differential Revision: https://phabricator.services.mozilla.com/D128073
-
André Bargull authored
`JSTYPE_NULL` was added for e4x. Differential Revision: https://phabricator.services.mozilla.com/D128072
-
André Bargull authored
Only because I noticed this while working on the next patch in this stack. Differential Revision: https://phabricator.services.mozilla.com/D128071
-
André Bargull authored
This isn't currently an issue, because the number of observed types is restricted to six, which means `JSVAL_TYPE_OBJECT` currently can't be last, but it seems nicer to explicitly handle this case, because otherwise it might confuse the reader and if we ever support seven or more types in the observed types set, we could introduce a subtle bug here. Differential Revision: https://phabricator.services.mozilla.com/D128070
-
André Bargull authored
Using `EnumSet` simplifies the code and makes it faster, for example the constructor is inlined at "-02" and set operations are all constant time. Differential Revision: https://phabricator.services.mozilla.com/D128069
-
Emilio Cobos Álvarez authored
Bug 1590247 - Don't reframe scrollable frames if we already have all needed anonymous content. r=dholbert This prevents jank when switching from overflow: auto -> hidden or such. Differential Revision: https://phabricator.services.mozilla.com/D128367
-
Emilio Cobos Álvarez authored
No behavior change. Differential Revision: https://phabricator.services.mozilla.com/D128370
-
Niklas Baumgardner authored
Differential Revision: https://phabricator.services.mozilla.com/D127303
-
ssummar authored
Differential Revision: https://phabricator.services.mozilla.com/D128388
-
Kimberly Sereduck authored
Bug 1734634: Update google-slides warm page load test to navigate to sub-page rather than about:blank r=perftest-reviewers,AlexandruIonescu Differential Revision: https://phabricator.services.mozilla.com/D128296
-
Kimberly Sereduck authored
Bug 1735540: Update ImageMagick url for Windows browsertime requirements r=perftest-reviewers,AlexandruIonescu Differential Revision: https://phabricator.services.mozilla.com/D128383
-
André Bargull authored
This change ensures there's no surprising performance difference between: ``` function Klass() { this.prop = 0; } new Klass(); ``` and: ``` function Klass() { this.prop = 0; } Klass.prototype = null; new Klass(); ``` In the first case, the created `this` object has `AllocKind::OBJECT4`, so adding "prop" is writing to a fixed slot. Without this change, the second case created an object with `AllocKind::OBJECT0`, which meant that adding "prop" allocated a new dynamic slot. Differential Revision: https://phabricator.services.mozilla.com/D128379
-
André Bargull authored
This follows the existing inlining support for constructors with an object prototype, but instead of guarding that the `prototype` slot is a specific object, the new operation guards that the `prototype` slot isn't an object. Differential Revision: https://phabricator.services.mozilla.com/D128378
-
Andrew Creskey authored
This fixes the root cause of the intermittent failure (missing keystrokes) -- the function to send keys was not strictly synchronous. We now wait for the input field to be populated before we proceed. Differential Revision: https://phabricator.services.mozilla.com/D128409
-
Tim Giles authored
Bug 1688607 - Enable autofill and capturing when there are multiple credit card number fields. r=sgalich Enable the feature only in Nightly. Add functionality for previewing and autofilling into multiple cc-number fields. Fix test_Lush.js case. Add logic to handle credit card saving/update when multiple cc-number fields are present. Add heuristic test for Lufthansa site. Add test for filling cc-number when there are multiple cc-number fields in a form. Add test for collecting multiple cc-number fields via collectFormFields. Add multiple cc-number fields case to onFormSubmitted test. Add multiple cc-number fields with maxlength=4 case to markAsAutofillField. Add implementation of the preview and fill test cases for multiple cc-number fields. Differential Revision: https://phabricator.services.mozilla.com/D127987
-
Leslie Orellana authored
Differential Revision: https://phabricator.services.mozilla.com/D128340
-
Mathew Hodson authored
This makes sure colorama stays in pylint_requirements.txt next time someone regenerates it on a non-Windows machine. Since colorama is only required by pylint on Windows. Differential Revision: https://phabricator.services.mozilla.com/D128426
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127410
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127407
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127406
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127405
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127404
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127403
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127402
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127401
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127400
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D127399
-
Dragana Damjanovic authored
Bug 1734198 - Close transactions with NS_ERROR_NET_RESET if a stateless reset is received on a HTTP/3 connection. r=necko-reviewers,valentin This is an appropriate error to set and it may cause transactions to be restarted if possible (e.g. no data has been received already and the method is safe). Differential Revision: https://phabricator.services.mozilla.com/D127877
-
Christoph Kerschbaumer authored
Differential Revision: https://phabricator.services.mozilla.com/D128475
-
Christoph Kerschbaumer authored
Bug 1735543: Update tests within remote/shared/messagehandler to work with https-first enabled r=webdriver-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D128470
-
Paul Zuehlcke authored
Bug 1732919 - Update requestStorageAccess.sub.window.js test expectations. r=anti-tracking-reviewers,timhuang Differential Revision: https://phabricator.services.mozilla.com/D128399
-
Paul Zuehlcke authored
Bug 1732919 - Update browser_webconsole_requestStorageAccess_errors for updated user activation requirement. r=nchevobbe The base patch updated the behavior of document.requestStorageAccess to require user activation and moved the user activation check to the top of the method. To test for the other rsA error messages, which are in the user activation guarded parts of the method, we need to simulate user activation. Requiring user activation also means we should not run the rsA requests in parallel to avoid side effects. Differential Revision: https://phabricator.services.mozilla.com/D128106
-
Paul Zuehlcke authored
Bug 1732919 - Update tests for new Storage Access API user activation behavior. r=anti-tracking-reviewers,timhuang Differential Revision: https://phabricator.services.mozilla.com/D127152
-