Bug 1837122 - Fix typo introduced in bug 1834446. r=firefox-build-system-reviewers,sergesanspaille, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180174

Bug 1834964 - Use the same logic for {llvm-,$toolchain-prefix-,}strip as for many other tools. r=firefox-build-system-reviewers,sergesanspaille

Whatever was making things fail with llvm-strip back when using
llvm-strip was made a possibility, doesn't seem to happen anymore, even
with the clang version we were using back then (clang 13).

Differential Revision: https://phabricator.services.mozilla.com/D179040

Bug 1834446 - Move otool detection to python configure. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178750

Bug 1834446 - Move install-name-tool detection to python configure. r=firefox-build-system-reviewers,andi

At the same time, fix the sole use of the tool to actually use what's
found by configure, and only enable that configure check when building
Spidermonkey standalone.

And while we're here, add llvm-install-name-tool to the list.

Differential Revision: https://phabricator.services.mozilla.com/D178749

Bug 1834446 - Find dsymutil in the clang directory automatically. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178747

Bug 1832209 - Remove a bunch of unused add_old_configure_assignment. r=firefox-build-system-reviewers,ahochheiden

- Last use of CROSS_COMPILE was removed in bug 1460620,
- Last use of EARLY_BETA_OR_EARLIER was removed in bug 1603834,
- Last use of RELEASE_OR_BETA was removed in bug 1670948,
- Last use of MOZILLA_VERSION was removed in bug 1745838,
- Last use of GNU_AS was removed in bug 1635764,
- Last use of AR was removed in bug 1638193,
- Last use of PKG_CONFIG was removed in bug 1747775,
- Last use of MOZ_DMD was removed in bug 1747970,
- Last use of NSPR_CFLAGS and NSS_CFLAGS were removed in bug 1722652,
- Last use of MOZ_PROFILING was removed in bug 1640578,
- Last use of USE_FC_FREETYPE was removed in bug 1747325,
- Last use of MOZ_FMP4 was removed in bug 1382930,
- Last use of MOZ_WEBSPEECH was removed in bug 1295480,
- MOZ_ASAN_REPORTER doesn't seem to have ever been used,
- Last use of MOZ_THUMB2 and ANDROID_CPU_ARCH were removed in bug 1814802,
- Last use of ARM_ARCH was removed in bug 1747753,

Differential Revision: https://phabricator.services.mozilla.com/D177581

... which turns out to be limited to configurations that build libopus,
libtheora and libvpx for ARM with GNU as. Nothing else in the tree
remains that is actively using the PERL variable.

Those uses might actually not even need a full perl installation, but
for now, let's go with what's easy.

Differential Revision: https://phabricator.services.mozilla.com/D177579

The last PERL use was removed from old-configure in bug 1520340.

Differential Revision: https://phabricator.services.mozilla.com/D177565

As a consequence, rename hybrid builds into non-unified builds in tree
herder.

Differential Revision: https://phabricator.services.mozilla.com/D176545

Tup is no longer a thing, afaict.

Differential Revision: https://phabricator.services.mozilla.com/D176226

It's useful for virtually all editors.
Also it works with Android builds, so remove that condition.

Differential Revision: https://phabricator.services.mozilla.com/D176225

Stop trying to use system zlib when building standalone SpiderMonkey for Android
targets and instead rely on the mozglue version. Additionally, use 'get_adb_path'
used by other geckoview tests to locate `adb` in a consistent way.

Also do some house-keeping in the documentation and log messages.

Differential Revision: https://phabricator.services.mozilla.com/D173466

Stop trying to use system zlib when building standalone SpiderMonkey for Android
targets and instead rely on the mozglue version. Additionally, use 'get_adb_path'
used by other geckoview tests to locate `adb` in a consistent way.

Also do some house-keeping in the documentation and log messages.

Differential Revision: https://phabricator.services.mozilla.com/D173466

Bug 1807907 - Cache the results of `try_invoke_compiler` on disk for re-use between different runs of configure r=firefox-build-system-reviewers,glandium

Differential Revision: https://phabricator.services.mozilla.com/D165671

Bug 1817372 - Allow -windows-msvc and -windows-gnu triplets as host and target. r=firefox-build-system-reviewers,andi

This is the first step before entirely deprecating the use of -mingw32
targets to mean msvc.

Differential Revision: https://phabricator.services.mozilla.com/D170169

Bug 1817372 - Refactor checks for the MSVC abi that take the form of a compiler check. r=firefox-build-system-reviewers,andi

We're soon going to introduce a new way to distinguish between the two
windows ABIs, so we factor out compiler checks that will need to be
adjusted to limit the amount of changes down the line.

Differential Revision: https://phabricator.services.mozilla.com/D170167

This reverts bug 1801826 and instead prepends the msys2 path only for
the build, which is a bit more sensible.

This allows us to remove the existing warning from old_configure, since
that can't happen now.

Differential Revision: https://phabricator.services.mozilla.com/D163073

Backed out changeset 028a7f4e4b32 (bug 1776255) for causing Linux artifact builds bustages on central CLOSED TREE

This reverts bug 1801826 and instead prepends the msys2 path only for
the build, which is a bit more sensible.

This allows us to remove the existing warning from old_configure, since
that can't happen now.

Differential Revision: https://phabricator.services.mozilla.com/D163073

Bug 1776255 - Add the appropriate 'when' to all 'option' that end up calling 'pkg_check_modules' later r=firefox-build-system-reviewers,glandium

We don't check for pkg-config on some platforms (Windows, OSX, Android).
On those platforms, calling 'pkg_check_modules' will not work. Adding
the same 'when' used for the 'pkg_config' check to all the options that
end up calling 'pkg_check_modules' effectively disables them, and prevents
'pkg_check_modules' from being called.

Differential Revision: https://phabricator.services.mozilla.com/D150649

Bug 1794517 - Make CI plain builds a little closer to local builds. r=firefox-build-system-reviewers,andi

Differential Revision: https://phabricator.services.mozilla.com/D159005

Historically, we had configure.in in the tree, and generated configure
with autoconf via client.mk at build time, and we'd run that configure.
As a side effect, configure would be shipped in source tarballs, as with
traditional autoconf-driven software.

Bug 1671424 changed that, and made `mach build`/`mach configure` invoke
configure.py directly, without needing configure. As a side effect,
configure stopped being generated in source directories. An unexpected
side effect was that configure stopped being shipped in source tarballs.

Anyways, it has been long enough now that adding a configure file in the
tree shouldn't cause too many problems with people updating their trees
where a configure file might exist from those older builds.

Differential Revision: https://phabricator.services.mozilla.com/D155923

Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium

Differential Revision: https://phabricator.services.mozilla.com/D150147

Backed out changeset d9571dde686f (bug 1773520)

Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium

Differential Revision: https://phabricator.services.mozilla.com/D150147

Differential Revision: https://phabricator.services.mozilla.com/D147011

Backed out changeset 813147df341c (bug 1769405)
Backed out changeset 6de9495c467d (bug 1769405)
Backed out changeset 9099ba749b1f (bug 1769405)
Backed out changeset 5f8e0141a0ed (bug 1769405)

Differential Revision: https://phabricator.services.mozilla.com/D147011

Differential Revision: https://phabricator.services.mozilla.com/D142308

This is needed for a few reasons:
* All mach commands can use virtualenvs, not just `build`-related
  commands, so the files don't make sense to be in `build/`.
* When locking is added, more files associated with virtualenvs will be
  added, and this will change will ease the related directory structure
  setup.
* This removes the need for a redundant "_virtualenv_packages" keyword
  as part of the manifest filenames.

Differential Revision: https://phabricator.services.mozilla.com/D140382

As a bonus, we also check and prefer llvm-strip when it's suitable.

Differential Revision: https://phabricator.services.mozilla.com/D136976

As a bonus, we also check and prefer llvm-objcopy when it's suitable.

Differential Revision: https://phabricator.services.mozilla.com/D136975

Backed out changeset da8f11880896 (bug 1596656)
Backed out changeset 6c8f3c0aac51 (bug 1596656)

As a bonus, we also check and prefer llvm-strip when it's suitable.

Differential Revision: https://phabricator.services.mozilla.com/D136976

As a bonus, we also check and prefer llvm-objcopy when it's suitable.

Differential Revision: https://phabricator.services.mozilla.com/D136975

- AC_HAVE_FUNCS is an alias to AC_CHECK_FUNCS, so it is covered.
- Nothing uses HAVE___CXA_DEMANGLE, so we don't explictly set it,
  although we do need the result of whether __cxa_demangle is supported.
- No moz.build uses MOZ_DEMANGLE_SYMBOLS, so we only `set_define` it.
- We leave dladdr in old-configure because it needs to move along other
  dl* things.
- The hotfix for AC_CHECK_FUNC is however not needed for dladdr, so we
  remove it.
- We replace the forced HAVE_LOCALECONV on Windows with a check shared
  with all platforms.

Differential Revision: https://phabricator.services.mozilla.com/D134858

- AC_HAVE_FUNCS is an alias to AC_CHECK_FUNCS, so it is covered.
- Nothing uses HAVE___CXA_DEMANGLE, so we don't explictly set it,
  although we do need the result of whether __cxa_demangle is supported.
- No moz.build uses MOZ_DEMANGLE_SYMBOLS, so we only `set_define` it.
- We leave dladdr in old-configure because it needs to move along other
  dl* things.
- The hotfix for AC_CHECK_FUNC is however not needed for dladdr, so we
  remove it.
- We replace the forced HAVE_LOCALECONV on Windows with a check shared
  with all platforms.

Differential Revision: https://phabricator.services.mozilla.com/D134858