- Feb 04, 2023
-
-
Emilio Cobos Álvarez authored
Includes fix for bug 1803268.
-
- Dec 29, 2022
-
-
Kershaw Chang authored
Bug 1807879 - Remove MOZ_DIAGNOSTIC_ASSERT_ENABLED for mSheetCompleteCalled and mIntentionallyDropped, r=emilio a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D165658
-
- Dec 27, 2022
-
-
Kershaw Chang authored
-
- Sep 12, 2022
-
-
Emilio Cobos Álvarez authored
We had zero tests for this, and when I implemented the optimization to avoid reframing in most cases I apparently swapped the arguments ;_; Fix <input type=search> which suffered from the same issue, but we don't ship by default. Differential Revision: https://phabricator.services.mozilla.com/D155394
-
- Sep 06, 2022
-
-
Olli Pettay authored
Differential Revision: https://phabricator.services.mozilla.com/D156605
-
- Jul 12, 2022
-
-
Emilio Cobos Álvarez authored
I don't think why we have a mobile stylesheet (IIUC Android doesn't have tooltips...), but I noticed that most tooltip styles are the same and it should be doable to just unify them in xul.css. We can't keep the platform-specific bits on their own stylesheet because it loads _before_ xul.css, and thus overrides wouldn't quite do. Depends on D151640 Differential Revision: https://phabricator.services.mozilla.com/D151641
-
- May 28, 2022
-
-
Emilio Cobos Álvarez authored
None of the consumer need to mutate styles, and this saves some ugly const_casting on the next patch. Doesn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D147555
-
- May 23, 2022
-
-
Emilio Cobos Álvarez authored
MANUAL PUSH: Trivial orange fix CLOSED TREE
-
Emilio Cobos Álvarez authored
Differential Revision: https://phabricator.services.mozilla.com/D146432
-
- May 21, 2022
-
-
Emilio Cobos Álvarez authored
We could have a different property or something but this seems reasonable as well probably. Differential Revision: https://phabricator.services.mozilla.com/D146994
-
- May 20, 2022
-
-
Cristian Tuns authored
Backed out changeset c2e017726323 (bug 1769512) for causing multiple failures(wr and c1) CLOSED TREE
-
Emilio Cobos Álvarez authored
Differential Revision: https://phabricator.services.mozilla.com/D146432
-
- May 19, 2022
-
-
Emilio Cobos Álvarez authored
These should be trivial fixes for the most part, just fixing assumptions for constructable stylesheets which have no owner node. Since Gecko internally also has the concept of "associated document", let's just use that. We don't have the authored text around for these. We could keep it around but I'd kinda prefer we didn't have to just for devtools, since it seems to me we already need to deal with rules not being there (imagine e.g. an empty style element with all the rules inserted via script with insertRule()). So returning the empty string should be reasonable for now... Writing some tests now... Differential Revision: https://phabricator.services.mozilla.com/D146682
-
Emilio Cobos Álvarez authored
These should be trivial fixes for the most part, just fixing assumptions for constructable stylesheets which have no owner node. Since Gecko internally also has the concept of "associated document", let's just use that. We don't have the authored text around for these. We could keep it around but I'd kinda prefer we didn't have to just for devtools, since it seems to me we already need to deal with rules not being there (imagine e.g. an empty style element with all the rules inserted via script with insertRule()). So returning the empty string should be reasonable for now... Writing some tests now... Differential Revision: https://phabricator.services.mozilla.com/D146682
-
- May 17, 2022
-
-
Emilio Cobos Álvarez authored
After bug 1768278 and bug 1767815 there's no more uses of the cliprounded value in the tree (also it causes artifacts on HiDPI screens so we probably don't want new usages). The "sheet" value is unused, and the other values other than "default" and "none" are only derived from "default", so they don't need to be exposed in the style system. Differential Revision: https://phabricator.services.mozilla.com/D145821
-
- May 13, 2022
-
-
Emilio Cobos Álvarez authored
It's been enabled-by-default for years. Differential Revision: https://phabricator.services.mozilla.com/D146309
-
Emilio Cobos Álvarez authored
See bug comments for reasoning. While this could cause undistinguishable selected options when the select doesn't have focus, the idea is that this shouldn't be happening often. This matches other browsers. Differential Revision: https://phabricator.services.mozilla.com/D146059
-
Emilio Cobos Álvarez authored
Teach nsDisplay{Filters,BackdropFilters} to use a style that doesn't belong to mFrame for the root frame, and use it as needed. Remove the BackdropFilters::CanCreateWebrenderCommands call because it was testing for StyleSVGEffects::mFilters rather than mBackdropFilters, so it was doing nothing. Differential Revision: https://phabricator.services.mozilla.com/D146188
-
- May 10, 2022
-
-
Jonathan Kew authored
Callers that use the family's list of fonts need to hold a read lock for as long as they're accessing the list. Alternatively, the work can be moved into a gfxFontFamily method that locks internally. Differential Revision: https://phabricator.services.mozilla.com/D145924
-
- May 09, 2022
-
-
Kagami Sascha Rosylight authored
Bug 1768189 - Part 47: Apply modernize-concat-nested-namespaces to layout/style/MediaQueryList.h ... r=andi Depends on D145782 Differential Revision: https://phabricator.services.mozilla.com/D145783
-
Kagami Sascha Rosylight authored
Bug 1768189 - Part 46: Apply modernize-concat-nested-namespaces to dom/xslt/xpath/XPathResult.h ... r=andi Depends on D145781 Differential Revision: https://phabricator.services.mozilla.com/D145782
-
- May 06, 2022
-
-
Emilio Cobos Álvarez authored
Document::GetReferrerInfo is not what we want (that is the referrer of the document itself). What we want is to use the document _as_ the referrer. That's what regular stylesheets do, and that fixes our chrome only rules enabled check. Differential Revision: https://phabricator.services.mozilla.com/D145794
-
Emilio Cobos Álvarez authored
The non-native theme draws the button arrow nowadays always, so these backgrounds never really get painted. No behavior change. Depends on D145713 Differential Revision: https://phabricator.services.mozilla.com/D145714
-
Emilio Cobos Álvarez authored
The select button is native anonymous so it can't be overridden by content anyways. This patch doesn't change behavior. Depends on D145712 Differential Revision: https://phabricator.services.mozilla.com/D145713
-
Emilio Cobos Álvarez authored
Don't generate the button if the combobox doesn't need it anyways (if the appearance is not menulist). While at it improve the code that reframes on appearance: textfield changes so that it only applies to number inputs as it should. This shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D145712
-
- May 05, 2022
-
-
David Shin authored
Bug 1766886 - Use `mozilla::variant` in `ComputedTimingFunction` to contain the function implementation. r=boris Also minor refactorings: - Less Init() calls - Remove unused `Compare` functions - Add explicit casts to narrowing conversions Differential Revision: https://phabricator.services.mozilla.com/D145014
-
Emilio Cobos Álvarez authored
There's nobody working on it, and tooltips should hopefully be nice enough after recent changes (bug 1765423). Having it enabled causes artifacts like bug 1767815 comment 3. We can always rescue this from hg history if needed. Differential Revision: https://phabricator.services.mozilla.com/D145621
-
- May 03, 2022
-
-
Iulian Moraru authored
Backed out changeset a7fae9e0df25 (bug 1766886) for causing build bustages on TimingParams.h. CLOSED TREE
-
David Shin authored
Bug 1766886 - Use `mozilla::variant` in `ComputedTimingFunction` to contain the function implementation. r=boris Also minor refactorings: - Less Init() calls - Remove unused `Compare` functions - Add explicit casts to narrowing conversions Differential Revision: https://phabricator.services.mozilla.com/D145014
-
Emilio Cobos Álvarez authored
Differential Revision: https://phabricator.services.mozilla.com/D145231
-
Emilio Cobos Álvarez authored
Bug 1759686 - Extend part 4 to resolve keyword sizes correctly, and reuse existing code to turning lengths into absolute pixels. r=jfkthame I think it doesn't make sense to support em/percentages without supporting smaller/bigger/other font-relative things. I have many questions about how other units like viewport-units etc are supposed to behave. Blink seems to resolve viewport units to zero: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/resolver/font_style_resolver.cc;l=15-27;drc=5e62802ab420dc1743a1824ec4b537a730b2b24b Which might be reasonable, but I think keeping a simple model consistent with what other code like DOMMatrix does seems better for now. Differential Revision: https://phabricator.services.mozilla.com/D144455
-
Jonathan Kew authored
Bug 1759686 - patch 4 - Extend ServoCSSParser::ParseFontShorthandForMatching to (optionally) return font size in addition to family/style. r=emilio When running in a Worker, the canvas2d SetFontInternal method can't call GetFontStyleForServo because it doesn't have a canvasElement or presShell to pass. But we can use the method ServoCSSParser::ParseFontShorthandForMatching to parse the canvas 'font' property, if we extend it so as to also return the size from the font shorthand. (This is incomplete by itself; Emilio's following patch fixes it up, so the intention is to land them together.) Depends on D144186 Differential Revision: https://phabricator.services.mozilla.com/D144187
-
Tooru Fujisawa authored
Differential Revision: https://phabricator.services.mozilla.com/D144088
-
- Apr 30, 2022
-
-
Daniel Holbert authored
This patch does not impact behavior; it's just formatting changes. This patch was automatically generated by the following command: ./mach clang-format -p layout Differential Revision: https://phabricator.services.mozilla.com/D145163
-
Dan Robertson authored
This changes BaseMatrix::ScaleFactors() to return a ScaleFactors2D instead of a SizeTyped. Depends on D145041 Differential Revision: https://phabricator.services.mozilla.com/D144666
-
- Apr 28, 2022
-
-
Emilio Cobos Álvarez authored
Bug 1752392 - Don't drop CSSStyleSheet.cssRules from CSSStyleSheet.replace/Sync(). r=firefox-style-system-reviewers,layout-reviewers,boris As per spec this object should always return the same JS object. Differential Revision: https://phabricator.services.mozilla.com/D144569
-
Cristian Tuns authored
Backed out 2 changesets (bug 1644102, bug 1752392) for causing mochitest failures in test_parseStyleSheetImport.html CLOSED TREE Backed out changeset b5c0bdafaf5e (bug 1644102) Backed out changeset 092814d96f1d (bug 1752392)
-
- Apr 27, 2022
-
-
Emilio Cobos Álvarez authored
Bug 1752392 - Don't drop CSSStyleSheet.cssRules from CSSStyleSheet.replace/Sync(). r=firefox-style-system-reviewers,layout-reviewers,boris As per spec this object should always return the same JS object. Differential Revision: https://phabricator.services.mozilla.com/D144569
-
Emilio Cobos Álvarez authored
Bug 1766020 - Add support for parsing container-query-specific features. r=firefox-style-system-reviewers,layout-reviewers,boris There are some mediaqueries-5 features that we still don't support and explain the remaining failures in at-container-{parsing,serialization}. Differential Revision: https://phabricator.services.mozilla.com/D144446
-
Emilio Cobos Álvarez authored
Bug 1617948 - Make some inspector methods deal with adopted stylesheets. r=nchevobbe,firefox-style-system-reviewers,boris And simplify the tests while at it. Differential Revision: https://phabricator.services.mozilla.com/D144566
-