MSYS2 has a slightly different directory structure (binaries are
now under "/usr/bin/" instead of "/bin/"), and we're now plonking
it in `%MOZILLABUILD%\msys2` instead of `%MOZILLABUILD%\msys` so that
MSYS1 files don't interfere with MSYS2 after a pave-over install.

Speaking of pave-over installs: if both `msys2` and `msys` are available,
this patch prefers `msys2`. This is because MozillaBuild installations
with MSYS2 are going to _assume_ they're using MSYS2, and therefore
be most compatible with the versions of packages shipped with MSYS2.

Differential Revision: https://phabricator.services.mozilla.com/D133549

Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045

Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE

Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)

Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky

Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045

Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky

Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045

Backed out 3 changesets (bug 1455127) for throughing exceptions and messing with windows 2012 builds on a CLOSED TREE, a=backout

Backed out changeset ac17015816ca (bug 1455127)
Backed out changeset 8527e727b92d (bug 1455127)
Backed out changeset 8c8fe0facf52 (bug 1455127)

The argument is never used in the local file copying function. So let's
nuke the argument.

MozReview-Commit-ID: JeU4LaVvGD7

--HG--
extra : rebase_source : a898814f4084288200928f062fbb06ffbbae60bd

This was only used for the remote server case. That code was recently
deleted.

MozReview-Commit-ID: 7usqWZ7CuBR

--HG--
extra : rebase_source : 39c33057aab6773f8f85b1294e4965965954d9e6

With the transition to Taskcluster, "uploads" are artifacts in a local
directory. So we don't need to support uploading to a remote server
using SCP.

This commit removes all the code to support uploading to a remote
server.

And since property files were only written out for the remote case, all
that code can be deleted as well.

Since UPLOAD_HOST no longer means anything, we no longer set it in
mozharness configs.

MozReview-Commit-ID: 66gkM8erkGk

--HG--
extra : rebase_source : 15143a18598370eeaaa98f8f0ac8458d758db51f

The argument is never used in the local file copying function. So let's
nuke the argument.

MozReview-Commit-ID: JeU4LaVvGD7

--HG--
extra : rebase_source : 0e305c5bff0e3871fd11a554d75e7f53ceea4bdd

This was only used for the remote server case. That code was recently
deleted.

MozReview-Commit-ID: 7usqWZ7CuBR

--HG--
extra : rebase_source : f27b37391802a2980feffa5d88c92228d137824f
extra : source : 46b8a00288c8d7b88fd9b7aee20e88ddfd96d57b

With the transition to Taskcluster, "uploads" are artifacts in a local
directory. So we don't need to support uploading to a remote server
using SCP.

This commit removes all the code to support uploading to a remote
server.

And since property files were only written out for the remote case, all
that code can be deleted as well.

Since UPLOAD_HOST no longer means anything, we no longer set it in
mozharness configs.

MozReview-Commit-ID: 66gkM8erkGk

--HG--
extra : rebase_source : ee85bb927cfb98e1ca383ab2591febfc1f0ce5cd

This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.

This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`.  If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.

Of course, being specific is often better than a catch all.

MozReview-Commit-ID: FKx80MLO4RN

--HG--
extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b

Bug 1406650 - Make build/*.py and a few other files flake8 compatible and add them to the list of files to check r=chmanchester

MozReview-Commit-ID: icmFJtbWdN

--HG--
extra : rebase_source : 7b2ef783822bcad7f955bad8cbd6cea6df588f92

MozReview-Commit-ID: Lmg5SAtLuE3

--HG--
extra : rebase_source : 80f753be34759a366a6cf10847a546f9484d40ca

Use concurrent.futures to provide a thread pool so we upload
files concurrently. This should make uploading complete faster.

If timestamps in mozharness logs can be trusted, uploading on Linux
currently takes ~45s. Hopefully this shaves 10+s from the build.

MozReview-Commit-ID: KTww31XWN7o

--HG--
extra : rebase_source : 1a487cd1a0772e996eacaefcd9d0b37dc96fbffa

In preparation of using a thread pool to call DoSCPFile().

MozReview-Commit-ID: Ab2gk8UTQWK

--HG--
extra : rebase_source : b1c97953f5b0be91bb16eac19ca6862e715ce7d4

Most files go to the same directory. This should cut down on the number
of scp sessions we establish as part of directory creation.

MozReview-Commit-ID: LpKwgUZhLEO

--HG--
extra : rebase_source : f7ed0490a0fd8d0f01066090af16d751864039df

We'll call this multiple times in a subsequent commit. I hate DRY
violations.

MozReview-Commit-ID: Khai4EZkPCS

--HG--
extra : rebase_source : f58ac817c4956e22821ef36ae89b3e889ca4b005

This is still referenced out of tree, but only to optionally (!) find
it or to ignore it:

http://mxr.mozilla.org/build/search?string=unsigned-unaligned&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build

MozReview-Commit-ID: Hq0TPVDzWOy

--HG--
extra : rebase_source : 2e3dcfc516a6bcc5fd0517ca8bd98a4df7358251
extra : amend_source : f65baf2789517f5bd38384db89c6d2ea3d84676f
extra : histedit_source : b901d25f4cbbf8bcecdf464a6042b5a44d51bea8

--HG--
extra : commitid : C1f3kiibCXn
extra : rebase_source : ed715e77014b91fb19c7a6bc7a0a04134f1e69cc
extra : amend_source : 46abf6b9bfc0f7993da9814d8f6e3959379c434f

Previously, buildbot was responsible for the retrying logic. Now that
'make upload' is part of mach build, we need to add retries here.

Bug 599748 - Remove custom |def check_call()|, now that Python 2.4 is unsupported; (Av1) Remove 'util.py'.
r=ted.mielczarek.

--HG--
extra : rebase_source : 5f1aabdc164d755ac20735a09578a1fede6de485

Bug 599748 - Remove custom |def check_call()|, now that Python 2.4 is unsupported; (Av1) Remove 'util.py'.
r=ted.mielczarek.

bug 486992: post_upload.py errors aren't caught - use sys.exit(non-zero) when exceptions are caught in upload.py. r=ted

bug 455578: create a post-upload script on stage to do release-to-dated, etc. - upload.py fixes and enhancements. r=ted

Followup fix for bug 454594 (need a makefile target that can upload files via ssh). r=bsmedberg, NPOB