Gabriele Svelto authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

On macOS versions prior to 10.15 os_unfair_locks cannot spin in kernel-space
which degrades performance significantly. To obviate for this we spin in
user-space like OSSpinLock does, for the same number of times and invoking
x86-specific pause instructions in-between the locking attempts to avoid
starving a thread that might be running on the same physical core.

Differential Revision: https://phabricator.services.mozilla.com/D154205

Gabriele Svelto authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

Bug 1774458 - Use undocumented, non-public adaptive spinlocks on macOS 10.15+, revert to user-space spinlocks on older versions r=pbone

Differential Revision: https://phabricator.services.mozilla.com/D149599

Gabriele Svelto authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium

Depends on D148287

Differential Revision: https://phabricator.services.mozilla.com/D99280

Gabriele Svelto authored 2 years ago and Pier Angelo Vendrame committed 1 year ago

Bug 1670885 - Fix post-fork() handlers for PHC/LogAlloc to work on macOS using unfair locks r=glandium

macOS unfair locks enforce that a lock can only be released by the thread which locked it.

On macOS 11+ this caused the fork()'d child process to raise a SIGILL signal. Confusingly enough this behavior seems to be different on macOS 10.15 and possibly interacted in odd ways with our exception handler if it was installed before fork()-ing.

Differential Revision: https://phabricator.services.mozilla.com/D148287

Backed out changeset d220d82e1b81 (bug 1670885)
Backed out changeset bf5d0e1ffcfd (bug 1670885)

Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium

Differential Revision: https://phabricator.services.mozilla.com/D99280

Differential Revision: https://phabricator.services.mozilla.com/D144202

Differential Revision: https://phabricator.services.mozilla.com/D140849

Differential Revision: https://phabricator.services.mozilla.com/D140849

Differential Revision: https://phabricator.services.mozilla.com/D140849

Differential Revision: https://phabricator.services.mozilla.com/D139567

Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges

While mingw builds don't require user32 and advapi32 explicitly, it doesn't
hurt for them to be there (and they're required for clang-cl build).
Likewise, while clang-builds don't require uuid and userenv explicitly
because they're pulled in via #pragmas in the source code, mingw doesn't
support those #pragmas and needs them explicitly, which doesn't hurt the
clang-cl builds.

Differential Revision: https://phabricator.services.mozilla.com/D134737

Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges

While mingw builds don't require user32 and advapi32 explicitly, it doesn't
hurt for them to be there (and they're required for clang-cl build).
Likewise, while clang-builds don't require uuid and userenv explicitly
because they're pulled in via #pragmas in the source code, mingw doesn't
support those #pragmas and needs them explicitly, which doesn't hurt the
clang-cl builds.

Differential Revision: https://phabricator.services.mozilla.com/D134737

For a unified it is possible to include FdPrintf.cpp before FdPrintf.h which
creates a compilation warning for FdPrintf's attributes.  FdPrintf.cpp
should include FdPrintf.h so that the declaration always precedes the
definition.

Depends on D132913

Differential Revision: https://phabricator.services.mozilla.com/D132914

Fix the reported error in Bug 1743713 plus a linker error.

Differential Revision: https://phabricator.services.mozilla.com/D132913

-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.

There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.

Differential Revision: https://phabricator.services.mozilla.com/D132289

Differential Revision: https://phabricator.services.mozilla.com/D132006

Differential Revision: https://phabricator.services.mozilla.com/D28516

Differential Revision: https://phabricator.services.mozilla.com/D131576

Backed out changeset 85fdbf7e368a (bug 1735482) for causing OS X build bustages on mozjemalloc.cpp. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D131576

Differential Revision: https://phabricator.services.mozilla.com/D131197

Differential Revision: https://phabricator.services.mozilla.com/D129807

Differential Revision: https://phabricator.services.mozilla.com/D129806

Differential Revision: https://phabricator.services.mozilla.com/D131576

Bug 1736968 - Change MOZ_CRASH() to MOZ_ASSUME_UNREACHABLE_MARKER() for abort()'s ARM noreturn case. r=glandium

This MOZ_CRASH() is redundant after calling noreturn function mozalloc_abort. The MOZ_ASSUME_UNREACHABLE_MARKER() annotation makes ARM's "function declared 'noreturn' should not return" warnings go away.

Differential Revision: https://phabricator.services.mozilla.com/D129115

Bug 1736968 - Pass mozalloc_abort() crash reason to MOZ_CRASH() to distinguish mozalloc_abort() and bare MOZ_CRASH() crashes. r=glandium

Differential Revision: https://phabricator.services.mozilla.com/D129114

Differential Revision: https://phabricator.services.mozilla.com/D129228

Backed out changeset 27b73fdbb4a9 (bug 1737199) for causing bustages on memory/replace/logalloc/replay/Replay.cpp. CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D129228

Differential Revision: https://phabricator.services.mozilla.com/D128983

jemalloc_stats takes an array for its second argument.  It expects this
array to have enough space for all the bins, previously the maximum was set
as a magic number.  To make it dependent on the configured bins this patch
replaces the compile-time constant with a function.

Differential Revision: https://phabricator.services.mozilla.com/D127761

Differential Revision: https://phabricator.services.mozilla.com/D128448

Differential Revision: https://phabricator.services.mozilla.com/D92729

Differential Revision: https://phabricator.services.mozilla.com/D92729