Bug 1837086 - Properly pass -pie when linking. r=firefox-build-system-reviewers,sergesanspaille, a=dmeehan

There was a syntax error introduced in bug 1796380 that removed the flag
entirely. In practice, it didn't make a difference for us because clang
now defaults to PIE, but it can make a difference in environments where
the compiler is not using such a default.

However, on both Darwin and WASI, clang complains the flag is unused, so
we have to do something about it.

Differential Revision: https://phabricator.services.mozilla.com/D180279

Bug 1836020 - Patch llvm-strip to strip as much as cctools's strip. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D179636

It's only used by glean in code that is not actually used. It allows to
remove the only use of dashmap, which is a rather complex crate.

Differential Revision: https://phabricator.services.mozilla.com/D179747

Bug 1836402 - Disable clap default features in uniffi-bindgen-gecko-js. r=bdk,supply-chain-reviewers

The tool is not directly user visible, and it's not super useful for
features like color to be enabled.

Differential Revision: https://phabricator.services.mozilla.com/D179742

Backed out changeset fb52e6ee18c6 (bug 1714690) for causing bustages at complaining about charmap. CLOSED TREE

Bug 1714690 - Remove usages of "six" in build/RunCbindgen.py. r=firefox-build-system-reviewers,glandium

Differential Revision: https://phabricator.services.mozilla.com/D178515

Bug 1834436 - Upgrade minimum supported GCC version to 8. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178736

Differential Revision: https://phabricator.services.mozilla.com/D179281

Differential Revision: https://phabricator.services.mozilla.com/D179392

Clang 17 made a change that made it an error to undefine _FORTIFY_SOURCE
on mac, because it's defined as a builtin when ASAN is enabled.
Defining it as 0 has the same effect of disabling it, but avoids the
error.

Differential Revision: https://phabricator.services.mozilla.com/D179398

Differential Revision: https://phabricator.services.mozilla.com/D179402

Bug 1835694 - Factor out a helper function for handling heuristic results in MozsearchIndexer. r=asuth DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D179401

Differential Revision: https://phabricator.services.mozilla.com/D178907

Differential Revision: https://phabricator.services.mozilla.com/D179374

Bug 1834955 - Upgrade minimum supported Clang-cl version to 9. r=firefox-build-system-reviewers,sergesanspaille

We have less constraints on the minimum supported clang-cl version, and
it would unlock C++17 inline variables (which had a bug on Windows
targets in clang up-to 8.x).

Differential Revision: https://phabricator.services.mozilla.com/D179037

Bug 1835428 - Do config.sub munging in a more generic way. r=firefox-build-system-reviewers,nalexander

This will allow to add other munging more easily in the future.

Differential Revision: https://phabricator.services.mozilla.com/D179280

Differential Revision: https://phabricator.services.mozilla.com/D179326

Differential Revision: https://phabricator.services.mozilla.com/D179205

Bug 1835189 - Make TARGET_OS in the build system mean the same as target.os in configure. r=firefox-build-system-reviewers,nalexander

The situation is confusing enough.

Eventually, we'll want to have TARGET_FOO mean the same as target.foo,
but let's start with the easy one.

Differential Revision: https://phabricator.services.mozilla.com/D179178

Bug 1835239 - Make the new -Wbuiltin-macro-redefined warning a non-error. r=firefox-build-system-reviewers,sergesanspaille

... until we fix the underlying issues.

Differential Revision: https://phabricator.services.mozilla.com/D179197

Differential Revision: https://phabricator.services.mozilla.com/D178734

It's the default and clang complains the argument is unused.

Differential Revision: https://phabricator.services.mozilla.com/D178733

Bug 1791961 - Re-enable C++20 -Wambiguous-reversed-operator warnings. r=firefox-build-system-reviewers,glandium

clang only reports these warnings when compiling with -std=c++20.

Depends on D179025

Differential Revision: https://phabricator.services.mozilla.com/D179026

Differential Revision: https://phabricator.services.mozilla.com/D179182

clang 17 is making void* deref a non-disablable error, and this tests
relies on the deref "error" being disablable. Arranging things to make
it not deref makes not different from test_ref_9, so remove it.

Differential Revision: https://phabricator.services.mozilla.com/D179031

Differential Revision: https://phabricator.services.mozilla.com/D179063

Bug 1833998 - Switch Firefox builds to macOS 13.3 SDK. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178500

Bug 1834446 - Move otool detection to python configure. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178750

Bug 1834446 - Move install-name-tool detection to python configure. r=firefox-build-system-reviewers,andi

At the same time, fix the sole use of the tool to actually use what's
found by configure, and only enable that configure check when building
Spidermonkey standalone.

And while we're here, add llvm-install-name-tool to the list.

Differential Revision: https://phabricator.services.mozilla.com/D178749

Nothing in the build system is using it anymore. It is still used on some
taskcluster tasks, but those are outside the build system.

Differential Revision: https://phabricator.services.mozilla.com/D178748

Bug 1834446 - Find dsymutil in the clang directory automatically. r=firefox-build-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D178747

Backed out changeset 26904179b913 (bug 1832022) for causing multiple crashes related to nsCOMPtr. CLOSED TREE

The compiler may be imperfect but it evolves, and hard-coded threshold
don't. Plus according to prefherder, the impact on size is within
reasonable bounds.

Differential Revision: https://phabricator.services.mozilla.com/D178152

Differential Revision: https://phabricator.services.mozilla.com/D178501

Bug 1833995 - Add a script to explore the Apple software update catalog. r=firefox-build-system-reviewers,gsvelto,sergesanspaille

and a doc on how to use it to find SDKs.

Differential Revision: https://phabricator.services.mozilla.com/D178497

Bug 1833958 - Upgrade minimum supported Clang version to 7. r=firefox-build-system-reviewers,sergesanspaille

Per
https://glandium.github.io/firefox-linux-compat-matrix/#scope=build&version=115&show_eol=false
this leaves out Ubuntu 16.04, which hasn't built a newer version of
Firefox since version 88.0, and SUSE SLE-12-SP4, which goes EOL next
month, so before 115 is released.

Differential Revision: https://phabricator.services.mozilla.com/D178485

Bug 1833272 - Handle templated heuristic results in VisitCXXDependentScopeMemberExpr. r=asuth DONTBUILD

Differential Revision: https://phabricator.services.mozilla.com/D178258

Bug 1834071 - Allow disabling thread-safety analysis. r=firefox-build-system-reviewers,sergesanspaille

This doesn't change behavior, it just adds an option to disable
thread-safety analysis in local builds. I want to measure it in
different machines, and this would be useful for that. It's also useful
to workaround stuff like bug 1833676 which causes my builds to OOM
frequently.

Differential Revision: https://phabricator.services.mozilla.com/D178540

Differential Revision: https://phabricator.services.mozilla.com/D178122