Bug 1837185 - Use realistic loader in test_webext_apis.js + fix failures r=devtools-reviewers,jdescottes, a=dmeehan

listAddons was broken because webbrowser.js imported AddonManager
through the wrong loader. Consequently, a new instance of the
AddonManager module was loaded, instead of the alreaady-initialized one
from the browser. This lead to the observed bug in the report.

test_webext_apis.js was not realistic because it did not use a dedicated
loader like DevToolsStartup. That prevented the test from catching the
regression. This patch fixes that by replicating the logic at
https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/devtools/startup/DevToolsStartup.sys.mjs#1075-1101

Differential Revision: https://phabricator.services.mozilla.com/D180253

Bug 1836771 - Add aria attributes to the message-bar notification used in the extensions panel. r=ayeddi, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179957

Bug 1837122 - Fix typo introduced in bug 1834446. r=firefox-build-system-reviewers,sergesanspaille, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180174

Bug 1837086 - Properly pass -pie when linking. r=firefox-build-system-reviewers,sergesanspaille, a=dmeehan

There was a syntax error introduced in bug 1796380 that removed the flag
entirely. In practice, it didn't make a difference for us because clang
now defaults to PIE, but it can make a difference in environments where
the compiler is not using such a default.

However, on both Darwin and WASI, clang complains the flag is unused, so
we have to do something about it.

Differential Revision: https://phabricator.services.mozilla.com/D180279

Before bug 1775784, RemoteWorkerChild's refcount was not threadsafe and
so RemoteWorkerChild-related logic went to great contortions to avoid
trying to create new refcounts off the worker launcher thread, leading
to the logic stealing the caller's RefPtr.  However, this was unsound
in the case that the RefPtr would be used after the creation of the
MessagePortIdentifierRuynnable, which was the case if dispatch of the
runnable failed.  This fix changes us to the standard XPCOM calling
convention of passing a raw pointer which the MPIR then acquires a
fresh strong refcount.  This code is not remotely performance
sensitive and the prior behavior was surprising, so there's no reason
to try and maintain the transfer of the refcount.

Differential Revision: https://phabricator.services.mozilla.com/D180063

No bug - Tagging 8ef0eed85dd1724df18acbc52ede7bda8d19d4ca with DEVEDITION_115_0b3_RELEASE a=release CLOSED TREE DONTBUILD

No bug - Tagging 8ef0eed85dd1724df18acbc52ede7bda8d19d4ca with FIREFOX_115_0b3_RELEASE a=release CLOSED TREE DONTBUILD

No bug - Tagging 8ef0eed85dd1724df18acbc52ede7bda8d19d4ca with DEVEDITION_115_0b3_BUILD2 a=release CLOSED TREE DONTBUILD

No bug - Tagging 8ef0eed85dd1724df18acbc52ede7bda8d19d4ca with FIREFOX_115_0b3_BUILD2 a=release CLOSED TREE DONTBUILD

Bug 1837201 - Ignore unsupported origin directories during various operations; r=dom-storage-reviewers,jstutte,asuth, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180349

Bug 1837201 - Ignore unsupported origin directories during various operations; r=dom-storage-reviewers,jstutte,asuth, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180349

This is effectively a backout of the following patches from Bug 1274959 except
we add comments and test coverage:
- Part 1 which made the DirectoryListingTask include symlinks in the results
  as exposed by Directory.getFilesAndDirectories.
  https://hg.mozilla.org/mozilla-central/rev/3f1e16d3bfb2
- Part 3 which made GetFilesHelper include symlinks in the results.
  https://hg.mozilla.org/mozilla-central/rev/e28c3a696524

Test coverage for getFilesAndDirectories is provided by
dom/filesystem/tests/test_basic.html by way of changes to its included file
dom/filesystem/tests/filesystem_commons.js and changes to the createTreeFile
helper in dom/filesystem/tests/script_fileList.js.

Test coverage for GetFilesHelper is provided by
dom/filesystem/tests/test_webkitdirectory.html and changes to the
createTestFile helper in dom/filesystem/tests/script_fileList.js.

Commenting out either of the `isLink` test in the relevant C++ code will cause
the given tests to fail on non-windows platforms.

Differential Revision: https://phabricator.services.mozilla.com/D178894

ach -> f76c6bd4d425f9b96ea490e5a34784288b8d019e
an -> 79a6b3eda1ad7cbbb7c0ece553c4bc9c56d44e99
ar -> ee2daa0aacc21badf832068399d929442b82f527
ast -> 164f6f0915b6461cc4ccf333f8b8818e0bbbc09c
az -> c0d195f9cc2630d4cf765a8d2df8ae21d41cbb51
be -> 4349f86ff84ac0e6aef9d830c517f739295d5fb7
bg -> 8e7796a1f2c2bd92c0aac75968f269206b6426de
bn -> 2c3c5b00a19370fb835de9a25f5798bd783541fa
br -> 782ed03b99b43279589e0c9cbb6767206e24fd8c
bs -> 8f39c650de01eb7fa87c0ae3b95fe511bf2cc3a3
ca -> 4259c649c0aa79fbf584a6f615f869cb4bc7b43d
ca-valencia -> 625f0a4536cb681bcb90168bd306c9e1cbb07c41
cak -> 68bb09347bffd2d1293a73dd9ce2a78d98976713
cs -> 3112c710376f2303ec58ba2143cf0ec5032cc580
cy -> f1eab19ce033c96c1ef89b39ea14c6664ef3906e
da -> cb0da11a0f17b2f1506292766c04f3f864a0a2e0
de -> 19c6b68c5e2ceb5d52eb68b44fe38f2c4ec7894a
dsb -> 68fd28f3b636075cf97d76f6683bf805684deeb6
el -> ba88bbfbbfac68580df56847d0b258f022dbaedb
en-CA -> bf3dca6c3d0cc2ccbe7350546f7dbe32147a5d53
en-GB -> 28311aae01e9f1d27f3e48babb0814a8252e02fb
eo -> 1f5d13d3d701de8230de007e5af4fd07e4cf5631
es-AR -> 042a5acd1d51a62427162711b5a271655835d1ce
es-CL -> 4d476f5c4f10101df802bbc7cf4f59a81f3933f0
es-ES -> 9b8c7e0c39f2b6d375fcb68c930924197c5865fd
es-MX -> 16dd9a6740878c11511c47aeaf1d4006e2736463
et -> 0d0227b5d7029c9c663afda6f0723dd797dfc5cf
eu -> 64b0ab7ddb717e8c4758ee093177457f57c81986
fa -> b3dfe954ae0218b09b8dd3ad87a02f83c2709761
ff -> 8cc7ee6037b6615405939d79807fd5d3daaf9b7c
fi -> d58e42845a3103732999dabe66eeb376d70e1fed
fr -> afca515181dcea9165669f66ed13153d615b5308
fur -> 9e63a153be53ed13ed6fe052beeb1f6d53b8200b
fy-NL -> 1eec52a377256c08e8796ff31d4e8876f9c05250
gd -> d4ac819a33c1919073432d1941518429e0a41b41
gl -> 679a7a969f36c74703952ae231cd49d3ae7b2dbc
gn -> 69058b29e88d7e1dba536ee235d75009a1527688
gu-IN -> dc402d4eb962539d35e4aa0214531ed831119051
he -> f84e7fb19b9683dc458be067a9b50b61fc576f19
hi-IN -> 78807a134bb619172ad960ad837b743eac3f3cca
hr -> 7c4440400dcd39cd8a6917ed57f79877e3860117
hsb -> 7fd79616455e4edb71776b39a4bbf2b76f375ec2
hu -> e14bc1d3354173cee67d30fcb5d18f7a20719335
hy-AM -> 9f63da68e9e891284d56f7c7e6d49850da8a39dc
ia -> 1cc67cc56a7d939872c199276f554c37c2cc238a
id -> fca3933c4dbff50ae9d59e4602eb0c6829a51df4
is -> 9c46a74e8f72757a196d922148a493d187a1d92d
it -> 78c82eabb48000dc0cf1b283f2c8dc43a712c1c5
ja -> 5763ff4ab538ca56e7c1a712144e1eb1506ff7d2
ja-JP-mac -> 55f30933875bb3a0a451caea5c3af9ce5a525993
ka -> fe351c2caeff69f240af15b231d6e11f43cfec3e
kab -> 9b14787ff9d1d7b0774a8c4c2dfa9fc132e301c0
kk -> 35ef39b6f194c28295b550368064840d48306839
ko -> af56f4d727e2ef817bf95a671d07bfc94686edae
lij -> 068a308fdf5bf968ba8bebc535363235e74750b4
lt -> 2fee3e490593a78a8ef42b3c8ea05d9d3aa14099
lv -> e4740c02ae6601d8bf25302e6416c3238215931a
mr -> 2adf095e284a4fa43c1ba8e9602ffa784bc20b24
ms -> 3cf7ab54efacfa90896e00aec5f431b75f8399c4
nb-NO -> 32528f47057102fc420f87f64f4842fe97f594f1
nl -> 137fe0308802a36b9cad9b28f274b50d700c3d5e
nn-NO -> 479adab9c493f125ec99c036f30f1f64f42aac70
oc -> 8502cc5292a62e0f43e509485313a9cd7b6cc6f9
pa-IN -> 7e698dac192efad2d2c4010818cdad5e6ad50f60
pl -> 552bd42fbd903f1a2bfb6b421ab690a6087133fa
pt-BR -> 23ef093e5f29968822f720a185c386d52e3ae798
pt-PT -> 3643aa753e66ce09c354f6e31ecc09e2b7d5b250
rm -> 8ac047218c8073537c67ef3b1795a07aeeda51c0
ro -> 502cc0e557abd59c64df8221148af357568aa7ae
ru -> bb1a535edb236ddcd5a1947f545c9747e7a53c02
sc -> ddaddc0948341f965bb0d1f82a6c02baaa70b23a
sco -> f936cd534ea785a5c84861baaea66ca1f6f8ae8f
si -> eee348b298d3490afba03e3658064b39d031850d
sk -> 9a1adf5453284b3f95d716524c95b33acc54191a
sl -> be4227a893e5e9ae4277663e4c4ffc3bf974b98a
sq -> 89de925c7ca4752ee5b542309bde33fb0751573a
sr -> 1b7d4c41cf10ff29aa65e5d86ee8a616c7bab4a7
sv-SE -> ea7de7289560fb44865d9bbd4ed8c6d169969743
szl -> 842d2097e5fd776a64d45ba6c88c5ad3b246a122
te -> 48e5e6e983a64f3306f17155351b2e0b8a566f0a
tg -> 98d3030dc1bbb14cd6e7baf845c7c8b2062cc430
th -> 6dd924b0273b1926788a2818fed308b45ec4b7bb
tl -> 527069ae36bd8cb5374703a5a4306b1e499e4318
tr -> 1af429e2677dbda188d3c2301bc104a6e46355c5
trs -> d09b41aa82e023b6c740b1fddb4fbc2b65972305
uk -> fadee8136105dd7195aa2035b82a84c2b45e78ff
ur -> 1ae1751c720871ebabc7163c3e62bc0058aab5d2
vi -> 162114afd00fa5f60f6239c9ae2a1d03690d5983
zh-CN -> 6de1a7dffcfe75db78828886be32923e90af7aaa
zh-TW -> 18ddf27cb551aa5c57261b4bffea1669d7c6a07a

Differential Revision: https://phabricator.services.mozilla.com/D180316

Bug 1836585 - Change the "Top pick" label to "Firefox extension" for addon suggestions. r=daisuke,fluent-reviewers,flod, a=dmeehan, l10n=flod

This uses the new label but only when the addon suggestion is shown as a best
match. Otherwise the suggestion will be shown in the usual Firefox Suggest group
so it should use that label.

I chose `-brand-product-name`, which is always "Firefox" even on Nightly. I
don't think it makes sense to talk about "Nightly extensions".

Differential Revision: https://phabricator.services.mozilla.com/D179868

Even tho https://github.com/rust-lang/rust/issues/112337 is IMO a rust
bug, it's easy to work around in our code and it doesn't really affect
expressiveness.

Differential Revision: https://phabricator.services.mozilla.com/D180065

Bug 1836723 - Link against ntdll for rustc 1.70. r=firefox-build-system-reviewers,ahochheiden, a=dmeehan

Building with rustc 1.70 adds a dependency to the ntdll library through
libstd using NtCreateFile/NtWriteFile (it previously picked the symbols
at runtime).

Differential Revision: https://phabricator.services.mozilla.com/D180011

This implements the new required matching behavior, which isn't based on min
keyword length anymore. This is how it works:

* Use the full keywords in remote settings to generate keywords that contain the
  first word plus each possible substring after the first word. For example if a
  full keyword is "video download", then generate these keywords: "video",
  "video ", "video d", "video do", etc. If a full keyword is only one word, then
  use it as is. The keywords never change even when the user clicks "Show less
  frequently". This is implemented in `onRemoteSettingsSync()`, and I modified
  `SuggestionsMap.add()` to make it easy to generate new keywords from the
  strings in `suggestion.keywords`.
* Keep track of the number of times the user clicked "Show less frequently" in
  `showLessFrequentlyCount`.
* When a suggestion is fetched from the suggestions map, filter it out if the
  search string isn't long enough given the `showLessFrequentlyCount`. This is
  done in `makeResult()`.

Other changes:

* I made some of the private properties in `AddonSuggestions` public so that the
  xpcshell test can easily use them. I think it's OK for them to be public.
* Added `show_less_frequently_cap` to the RS config object so that we can
  specify a cap in RS as well as Nimbus.
* mv'ed test_quicksuggest_addResults.js to test_suggestionsMap.js, since I
  modified this file. I should have done that back when I replaced `addResults()`
  with `SuggestionsMap`.
* Fixed a bug in `SuggestionsMap.add()` where the same suggestion could be added
  multiple times to the array stored in the map, if it had duplicate keywords.

Differential Revision: https://phabricator.services.mozilla.com/D179867

Differential Revision: https://phabricator.services.mozilla.com/D180021

cy -> 2d6b7baafd10924112c0d5817b1c7fff4c403e03
de -> ec98fb74db0a484dd0a4b77cfe133805ae08888a
es-AR -> 0fc410704d3d48eae1d6ace08c3eaa32f20497a9
fr -> 913339aa9121f1dbcb6f78c8e6e5676f68a195ff
he -> e8f376a3164397890841084dec220f3e267bca35
it -> 8be5b6bff2b29e0447a486e9d2ceef962142e8d7
ka -> 7b6a492d07042210acd107d247fad702c6ceec86
ko -> c6722f9c30add583ffd691227a8d4d99f2483849
oc -> 01610a448076c31113dbfd427a00f9c79aa32f1d
ru -> a6c8cb735bc5bf3df71dc2cf9514cce5f9304b25
sk -> 9b1ba3c0d78b76024aae4e7aa48cfadacde32ae1
tr -> 8411f3a86b8b608a885ee02d4e65c021081ae358
zh-CN -> 891e4ba6e0986c3a00ca439f422288e57f5ebe34

Bug 1833790 - Ignore StrongWorkerRef callback if mWorkerRef is already cleared. r=dom-worker-reviewers,asuth, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D180072

It is unfortunately undefined behavior and leads to problems with LLVM
16.

Differential Revision: https://phabricator.services.mozilla.com/D180061

Differential Revision: https://phabricator.services.mozilla.com/D180103

Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckoview-reviewers,Standard8,m_kato, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179890

Bug 1836597 - Properly implement operator== for TimeUnit that overflow int64_t. r=media-playback-reviewers,chunmin, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179959

Bug 1836597 - Add more ToString methods on TimeUnit related classes. r=media-playback-reviewers,chunmin, a=dmeehan

Differential Revision: https://phabricator.services.mozilla.com/D179961

No bug - Tagging 10ed1bfdc481f14670072cdbf87a69d9212c0d6c with DEVEDITION_115_0b2_RELEASE a=release CLOSED TREE DONTBUILD

No bug - Tagging 10ed1bfdc481f14670072cdbf87a69d9212c0d6c with FIREFOX_115_0b2_RELEASE a=release CLOSED TREE DONTBUILD

No bug - Tagging 10ed1bfdc481f14670072cdbf87a69d9212c0d6c with DEVEDITION_115_0b2_BUILD1 a=release CLOSED TREE DONTBUILD

No bug - Tagging 10ed1bfdc481f14670072cdbf87a69d9212c0d6c with FIREFOX_115_0b2_BUILD1 a=release CLOSED TREE DONTBUILD

ach -> 8906b11d66192ba62dba9696f934a3dd0e0cda63
an -> 177de943c085d0ee6ca9ed85169d98c6aff8762e
ast -> 3cee34db5105bed03d491b9fc44e68474d18fca1
be -> d3072ea520a4a21630aff4ba8c7380d35b4968c5
bg -> 8abc48d1c3b94773710106f046b49f43fec5f10d
bn -> a4b9b302b7b4f05386f888f72430c03267e611c9
br -> f52cee88977dc561595409e66537739bf7594bd4
ca -> 0f0c95d9565518fa3964305675eb8ac72024adcf
ca-valencia -> 50786d873ff0ff429533f0350936ca0ceab2673a
cak -> 464e6c8772a2917da839aec115cadec68279e9b9
cs -> b4a1e418a7001be22f7c356a3550c083eaa56f4c
cy -> 3a0354ac592cf1dd9c11edcfe72b5828962a994a
da -> f3c12db23c05039eb94abaa8006fa022f0e046da
de -> aa164bf4091ebbded655d00f804541a538823b5f
dsb -> d48cc30bbf1180f4021d1b935d3364a8ad8fec12
el -> 05d307c0569e49246ed9bfaf3966da42ebb3954a
en-CA -> e562e11637875afccbf2faa4d6f83e797f329181
en-GB -> f22e27b52fa01fdcd384e92da451b8a66f2d34cf
eo -> 05c8d6257bd3b1c3089b3da379fb9c123f7d1716
es-AR -> 3b4cf805a90fde41d46fdc0052fc240d290c8ea1
es-CL -> 85eab29e38f47881e5402f47fcb6b8bf873b9bee
es-ES -> 3c64b4de6242e7c8252220ba687656606bd6b0dd
es-MX -> e979d8e75fe338ea7b48ece51be894b9071758c3
et -> 47ba41e7068e961657cf56eeb10055313cd2b894
eu -> 598f13064fcf8daadeac05649b763cabdaaa64fa
fa -> 78d7eaa6ef00738035b7d2f6af745d4dbf40b9b5
fi -> 04df63ecb0d10f39b6b153cb9686ab04ad674064
fr -> 45297f497453f53c72b955233f896686ca93c8cc
fur -> 53bd97b9194110f5b9270a868ab9d61ec2e29728
fy-NL -> 6a5a6c6335914777cebdc3718118ad5e63dcfd64
gd -> f94284c70a896a89d841622d8c9307603bcf1b3a
gl -> 658cd6876d4fc8a9936ec47924e3dff3d0837dc3
gn -> a3e05c5b2fa73b2f3c149eb621ee5829945a5144
he -> f5c8d351f7a57c80c1acc941e1cfc9cc42aa407f
hr -> d317fa6ade69c483bcf5f36b5343458b119cbc3c
hsb -> ad4a510bde0bb1b00043e2f81c38e5f2f6eade74
hu -> 62035742a615f7530e87a53e97ed8a323ea6fe06
hy-AM -> 53497103c2a89ccf8248959412a68172baad3343
ia -> a7f9322eb35691c43d63d8b3bde031f7cb173cb5
id -> e8fc4cfcf1f1b2bb7d83dd892367c65273ebf41b
is -> 294f931ac99908f4cc60977632dac8b67aa103d1
it -> 56614a613af586cc1e6c706200ec0f7d74b61325
ja -> 250b4086b1fa3a84273693352bf4add489bd22b0
ja-JP-mac -> ecc91c02994ee3b35662ac575541f6c7dc7e19ad
ka -> 0f9048256678cb6cf646fdf93c686ab79f0f2169
kab -> b27064252d4c5c53ece742abd59feba64a89fa60
kk -> 91fcd16f505589f6a3e42bbffc754c3d84e4986e
ko -> f8a780e760966e538574b95faa4aab9a51050ae4
lt -> 12b892fb63e5760533da15421da68cf1e5c5d68e
nb-NO -> 09ab32304bf47b44ef827125d4cac55719b8a13a
nl -> ad726453bad5e830b2319f44b77839fbd69049ec
nn-NO -> d88509623b8feef4faf277aa82c6b11d8b3095df
oc -> f4835f852a86233e4601cfa0faf06dc31fb4c626
pa-IN -> 1da08a5f53f16ee01a2d8b81ca726f049540f9ff
pl -> cfd110f5a2326adbcb803635d0f6eb4c7db654a3
pt-BR -> f8b4536f1de791bc660ee2c26371afa1fd7d4ade
pt-PT -> 5a7a7ce9650778b0a463c793819e02c6e696fa33
rm -> 3c2876e02cff1c5fd970aeece7fd0db63d889689
ro -> fc8b86d75780bd498d7ade4a2cdf29b03d4374ba
ru -> e589a1ba734363ee497f95ab1c10aa4eaddb5799
sc -> 84de4c3a955f734550cd4bf47321348ab6e32bfb
sco -> 827e3e0902e585aabd7fddb7384581825f7c5ec1
si -> ebbf4c13afaedaac38fd19d0bb48df2547b98e6f
sk -> e34088e55319ce84a52046e8e3031b1ee30dce41
sl -> 7ea840fbc8f74d374db4b6699dd1d7b1d3929f25
sq -> 3d4d57dd10671c71d8629a2ed81ef64cea2029fd
sr -> 2c21373a2421bd72f119d4340f44f5512d594be1
sv-SE -> df230776ed8599563e1c769a763c1c49d7da6d95
szl -> f278c2d2efad2d2223762fca87ae383436d340a4
tg -> 718c473ff6063cde8395cb24c18ff9244c762ae7
th -> 24a899189ca3e29473ce3e6ac5c7eaa285b9136c
tl -> df3bd5d586d89feed9e078f5543963fcb553e70f
tr -> 7cf858ea33ddfd7417557579eedd16e8430c5dad
trs -> 18174675241f286e907da4110a6ded6f45060424
uk -> 5289a6f3f5d5d4cde57ffae620c5d69a888abb66
uz -> f144b3c26da48ae422d9c1516baab358d60ff254
vi -> d986903c377fb4c824bd5c71d6ae6aeee8719fc3
zh-CN -> 51d5e364afbb17971e96404779eb21f42e805b31
zh-TW -> 9f457457c7114cf6f12fe09825547a8d14782584

This avoids leaking of places data across tests, which may affect suggested results.

Differential Revision: https://phabricator.services.mozilla.com/D179931

Bug 1825228 - Correctly await l10n completion in update tests r=application-update-reviewers,nalexander, a=test-only

This fixes two test issues:

- Use ContentTaskUtils.waitForEvent instead of
  BrowserTestUtils.waitForEvent for the part of the test that runs in a
  `SpecialPowers.spawn` environment - fixes bug 1825228.
- Await l10n translation completion in another place that was missed in
  the patch to bug 1835559. Fixes bug 1836504.

Differential Revision: https://phabricator.services.mozilla.com/D179863

No bug - Tagging 5f036ce2680a08b950cbfadd770beba129cbb195 with FIREFOX_115_0b1_RELEASE a=release CLOSED TREE DONTBUILD

No bug - Tagging 5f036ce2680a08b950cbfadd770beba129cbb195 with DEVEDITION_115_0b1_RELEASE a=release CLOSED TREE DONTBUILD

No bug - Tagging 5f036ce2680a08b950cbfadd770beba129cbb195 with FIREFOX_115_0b1_BUILD3 a=release CLOSED TREE DONTBUILD