Skip to content
Snippets Groups Projects
  1. May 09, 2022
  2. Mar 03, 2021
  3. Dec 15, 2020
  4. Nov 23, 2020
  5. Nov 04, 2020
  6. Sep 23, 2020
    • alwu's avatar
      Bug 1659060 - part1 : treat lock visible if corresponding document has in use... · 06a43c8c
      alwu authored
      Bug 1659060 - part1 : treat lock visible if corresponding document has in use picture-in-picture element. r=bryce,smaug
      
      When a tab is in the background, its document visibility would become invisible even if a tab owns a video which is visible because of being used in picture in picture mode.
      
      When a document changes its visibility, the wakelock would change its lockstate from `lock-foreground` to `lock-background`. For `video-playing` wakelock topic, we would only request a real platform lock for `lock-foreground` because we don't want to prevent screen from sleeping if the video is invisible.
      
      Therefore, considering if video is being used in picture in picture mode, when determining the wakelock's visible state. If video is still being used in picture in picture mode, then we would treat wakelock as if it's in foreground in order to keep a screen lock.
      
      Differential Revision: https://phabricator.services.mozilla.com/D90781
      06a43c8c
  7. Oct 26, 2020
    • Ricky Stewart's avatar
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`. · 02a7b4eb
      Ricky Stewart authored
      Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
      
      To produce this patch I did all of the following:
      
      1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
      
      2. Run ./mach lint --linter black --fix
      
      3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
      
      4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
      
      5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
      
      # ignore-this-changeset
      
      Differential Revision: https://phabricator.services.mozilla.com/D94045
      02a7b4eb
  8. Oct 24, 2020
    • Bogdan Tara's avatar
      Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for... · da1098d4
      Bogdan Tara authored
      Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
      
      Backed out changeset ff3fb0b4a512 (bug 1672023)
      Backed out changeset e7834b600201 (bug 1654103)
      Backed out changeset 807893ca8069 (bug 1518999)
      Backed out changeset 13e6b92440e9 (bug 1518999)
      Backed out changeset 8b2ac5a6c98a (bug 1518999)
      Backed out changeset 575748295752 (bug 1518999)
      Backed out changeset 65f07ce7b39b (bug 1518999)
      Backed out changeset 4bb80556158d (bug 1518999)
      Backed out changeset 8ac8461d7bd7 (bug 1518999)
      Backed out changeset e8ba13ee17f5 (bug 1518999)
      da1098d4
  9. Oct 23, 2020
    • Ricky Stewart's avatar
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`.... · c0cea3b0
      Ricky Stewart authored
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
      
      Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
      
      To produce this patch I did all of the following:
      
      1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
      
      2. Run ./mach lint --linter black --fix
      
      3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
      
      4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
      
      5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
      
      # ignore-this-changeset
      
      Differential Revision: https://phabricator.services.mozilla.com/D94045
      c0cea3b0
  10. Oct 22, 2020
  11. Oct 21, 2020
    • Ricky Stewart's avatar
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`.... · 50762dac
      Ricky Stewart authored
      Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
      
      Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
      
      To produce this patch I did all of the following:
      
      1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
      
      2. Run ./mach lint --linter black --fix
      
      3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
      
      4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
      
      # ignore-this-changeset
      
      Differential Revision: https://phabricator.services.mozilla.com/D94045
      50762dac
  12. Jul 01, 2020
  13. May 06, 2020
  14. Mar 04, 2020
  15. Dec 06, 2019
    • Gabriele Svelto's avatar
      Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan · ace6d106
      Gabriele Svelto authored
      The inclusions were removed with the following very crude script and the
      resulting breakage was fixed up by hand. The manual fixups did either
      revert the changes done by the script, replace a generic header with a more
      specific one or replace a header with a forward declaration.
      
      find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
          interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
          if [ -n "$interfaces" ]; then
              if [[ "$interfaces" == *$'\n'* ]]; then
                regexp="\("
                for i in $interfaces; do regexp="$regexp$i\|"; done
                regexp="${regexp%%\\\|}\)"
              else
                regexp="$interfaces"
              fi
              interface=$(basename "$path")
              rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
                  hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
                  if [ $hits -eq 0 ]; then
                      echo "Removing ${interface} from ${path2}"
                      grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                      mv -f "$path2".tmp "$path2"
                  fi
              done
          fi
      done
      
      Differential Revision: https://phabricator.services.mozilla.com/D55442
      
      --HG--
      extra : moz-landing-system : lando
      ace6d106
  16. Dec 04, 2019
    • Dorel Luca's avatar
    • Gabriele Svelto's avatar
      Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan · bc9290f7
      Gabriele Svelto authored
      The inclusions were removed with the following very crude script and the
      resulting breakage was fixed up by hand. The manual fixups did either
      revert the changes done by the script, replace a generic header with a more
      specific one or replace a header with a forward declaration.
      
      find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
          interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
          if [ -n "$interfaces" ]; then
              if [[ "$interfaces" == *$'\n'* ]]; then
                regexp="\("
                for i in $interfaces; do regexp="$regexp$i\|"; done
                regexp="${regexp%%\\\|}\)"
              else
                regexp="$interfaces"
              fi
              interface=$(basename "$path")
              rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
                  hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
                  if [ $hits -eq 0 ]; then
                      echo "Removing ${interface} from ${path2}"
                      grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                      mv -f "$path2".tmp "$path2"
                  fi
              done
          fi
      done
      
      Differential Revision: https://phabricator.services.mozilla.com/D55442
      
      --HG--
      extra : moz-landing-system : lando
      bc9290f7
  17. Sep 30, 2019
  18. May 01, 2019
  19. Apr 09, 2019
  20. Apr 05, 2019
    • Mike Hommey's avatar
      Bug 1541792 - Replace linker magic with manual component registration. r=froydnj · 071a2fe9
      Mike Hommey authored
      Before bug 938437, we had a rather large and error-prone
      nsStaticXULComponents.cpp used to register all modules. That was
      replaced with clever use of the linker, which allowed to avoid the mess
      that maintaining that file was.
      
      Fast forward to now, where after bug 1524687 and other work that
      preceded it, we have a much smaller number of remaining static xpcom
      components, registered via this linker hack, and don't expect to add
      any new ones. The list should eventually go down to zero.
      
      Within that context, it seems to be the right time to get rid of the
      magic, and with it the problems it causes on its own.
      
      Some of those components could probably be trivially be converted to
      static registration via .conf files, but I didn't want to deal with the
      possible need to increase the number of dummy modules in XPCOMInit.cpp.
      They can still be converted as a followup.
      
      Differential Revision: https://phabricator.services.mozilla.com/D26076
      
      --HG--
      extra : moz-landing-system : lando
      071a2fe9
  21. Mar 17, 2019
  22. Feb 25, 2019
  23. Jan 16, 2019
  24. Jan 18, 2019
  25. Jan 08, 2019
    • Nathan Froyd's avatar
      Bug 1517653 - give the power manager service its own xpcom module; r=mccr8 · 7618f587
      Nathan Froyd authored
      The layout module is a little weird.  It's described as being loadable
      in the GPU process, but very few of the contracts and CIDs it contains
      are also marked as such.  In fact, the sole reason the layout module is
      marked as being loadable in the GPU process is so that the power manager
      service can be registered; everything else is inconsequential.  This
      setup also means that the initializer for the layout module has to
      specifically check whether it's running in the GPU process (or several
      other processes...), so we don't try to spin up a bunch of stuff we
      don't need, like xpconnect and similar.
      
      This setup is silly: we should have a module solely for the power
      manager's use and that module can be loaded in the GPU process.  Then
      the layout module can go back to being an ordinary module, and we don't
      have to play games in its initialization method.
      7618f587
  26. Jan 07, 2019
    • shindli's avatar
      Backed out changeset 462d05bad533 (bug 1517653) for assertion failures in... · 501ce659
      shindli authored
      Backed out changeset 462d05bad533 (bug 1517653) for assertion failures in z:/build/build/src/js/src\vm/HelperThreads.h:361 CLOSED TREE
      501ce659
    • Nathan Froyd's avatar
      Bug 1517653 - give the power manager service its own xpcom module; r=mccr8 · 4517f227
      Nathan Froyd authored
      The layout module is a little weird.  It's described as being loadable
      in the GPU process, but very few of the contracts and CIDs it contains
      are also marked as such.  In fact, the sole reason the layout module is
      marked as being loadable in the GPU process is so that the power manager
      service can be registered; everything else is inconsequential.  This
      setup also means that the initializer for the layout module has to
      specifically check whether it's running in the GPU process (or several
      other processes...), so we don't try to spin up a bunch of stuff we
      don't need, like xpconnect and similar.
      
      This setup is silly: we should have a module solely for the power
      manager's use and that module can be loaded in the GPU process.  Then
      the layout module can go back to being an ordinary module, and we don't
      have to play games in its initialization method.
      4517f227
  27. Jan 03, 2019
    • Emilio Cobos Álvarez's avatar
      Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug · d2ed2608
      Emilio Cobos Álvarez authored
      Summary: Really sorry for the size of the patch. It's mostly automatic
      s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
      add the right namespacing and such.
      
      Overall it's not a very interesting patch I think.
      
      nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
      nsIDocumentInlines.h into DocumentInlines.h.
      
      I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
      
      While fixing up some of the bits I also removed some unneeded OwnerDoc() null
      checks and such, but I didn't do anything riskier than that.
      d2ed2608
  28. Nov 30, 2018
  29. Nov 28, 2018
  30. Sep 28, 2018
  31. Sep 06, 2018
  32. Aug 13, 2018
Loading