--HG--
extra : rebase_source : 59e789a23da08dd2b76079e2eba7e0a2d02cb2e7
extra : amend_source : f05b4780d1edd009b3a576dcb4d71ade976e2833

--HG--
extra : rebase_source : f565ae5e27cac5f712d7ca9efe185f7998ee9c54

Backed out changeset 304549224738 (bug 1530481)
Backed out changeset 171275cc24fb (bug 1530481)
Backed out changeset 1dab9495422d (bug 1530481)
Backed out changeset 0ada21a3af93 (bug 1530481)

Backed out changeset 3e21362cd4dc (bug 1536387) for build bustage at CacheFileUtils.cpp on a CLOSED TREE.

Differential Revision: https://phabricator.services.mozilla.com/D24358

--HG--
extra : moz-landing-system : lando

Depends on D24222

Differential Revision: https://phabricator.services.mozilla.com/D24223

--HG--
extra : moz-landing-system : lando

Depends on D24221

Differential Revision: https://phabricator.services.mozilla.com/D24222

--HG--
extra : moz-landing-system : lando

Doing this helps fixing the main target's path which is meant to be:
  /devtools/browser

Depends on D24220

Differential Revision: https://phabricator.services.mozilla.com/D24221

--HG--
extra : moz-landing-system : lando

This fixes the browser mochitest which currently timesout when calling server.close()
It started to timeout when the patch related to websocket handshake landed.

Depends on D24219

Differential Revision: https://phabricator.services.mozilla.com/D24220

--HG--
extra : moz-landing-system : lando

In this revision it only helps sharing `handle`.
But in a followup changeset, it will also help closing all the connections
and justify the `sessions` map we keep around.

Differential Revision: https://phabricator.services.mozilla.com/D24219

--HG--
rename : remote/targets/MainProcessTarget.jsm => remote/targets/Target.jsm
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D23810

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D23292

--HG--
extra : moz-landing-system : lando

This will take a very slight memory regression until JSOP is entirely
removed from ParseNode (which will regain a *lot* more memory).

Differential Revision: https://phabricator.services.mozilla.com/D24293

--HG--
extra : moz-landing-system : lando

Remove unnecessary css

Differential Revision: https://phabricator.services.mozilla.com/D24339

--HG--
extra : moz-landing-system : lando

Bug 1531119 - Remove editMenuCommands.inc.xul and make editMenuOverlay.js in charge of constructing the relevant commandset DOM r=bdahl,NeilDeakin

This allows us to drop preprocessing and makes it simpler to add edit menu functionality to any type of document.

Differential Revision: https://phabricator.services.mozilla.com/D21446

--HG--
extra : moz-landing-system : lando

Bug 1536788 - Reduce width of border between tabs and nav bar from 1 CSS pixel to 1 device pixel. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D24173

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D23948

--HG--
extra : moz-landing-system : lando

Bug 1535760 - Update strings and controls for toggling Picture-in-Picture from the context menu. r=jaws

Differential Revision: https://phabricator.services.mozilla.com/D23947

--HG--
extra : moz-landing-system : lando

Bug 1322645.  Fix intermittent test timeout by making sure our prefs are set before we start doing parts of the test.  r=jmaher

Differential Revision: https://phabricator.services.mozilla.com/D24307

--HG--
extra : moz-landing-system : lando

Depends on D23208

Differential Revision: https://phabricator.services.mozilla.com/D24051

--HG--
extra : moz-landing-system : lando

Bug 1536890 - Remove the workaround in chrome-remote-interface now that remote agent supports websocket handshake. r=ato

Differential Revision: https://phabricator.services.mozilla.com/D24225

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D24258

--HG--
extra : moz-landing-system : lando

Since these are compile-time constants, they can't exactly go away on us due to
running script, right?

Differential Revision: https://phabricator.services.mozilla.com/D24195

--HG--
extra : moz-landing-system : lando

Bug 1536825.  Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis.  r=andi

We need to typecheck the trivials too, not just the final thing after trivials
are stripped, because casts are trivials.

Differential Revision: https://phabricator.services.mozilla.com/D24186

--HG--
extra : moz-landing-system : lando

Bug 1536724.  Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes.  r=andi

Differential Revision: https://phabricator.services.mozilla.com/D24120

--HG--
extra : moz-landing-system : lando

The old code for member method calls did the following:

 1) Find the member method calls.
 2) Look at their "this" expression.
 3) If the "this" is an operator call, check for any of the arguments of the
    operator call being invalid.
 4) Otherwise (if not an operator call) check for the "this" value being
    invalid.

This wasn't right, because the "is invalid" check checks the type and only
considers refcounted things.  So if the code looked something like
"foo[i]->call_method()", we would look at the types of "foo" and "i" and
determine that none of those are refcounted types so there is nothing invalid
here (since "foo" is some sort of array type and "i" is an integer).  The new
setup just checks whether the "this" value is invalid, which does the type
check on the "this" value itself; in the "foo[i]->call_method()" case on
"foo[i]".  We then adjust the exclusions in InvalidArg to consider operator->
on known-live things valid, to allow the thing that we were really trying to
accomplish with the "check for an operator call" bits:
"stackRefPtr->some_method()".

The test coverage being added for the made-up TArray type is meant to catch
things like the geolocation issue that was being hidden by the buggy behavior.
I'm not using nsTArray itself because some header included by nsTArray.h
tries to define operator new/delete bits inline and that triggers warnings that
then cause a clang-plugin test failure, because they're unexpected.

Differential Revision: https://phabricator.services.mozilla.com/D24117

--HG--
extra : moz-landing-system : lando

Bug 1536336.  Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs.  r=andi

"this" is guaranteed to stay alive as long as other MOZ_CAN_RUN_SCRIPT
conditions hold, and its const members can't change value and drop
their refs.

Differential Revision: https://phabricator.services.mozilla.com/D23997

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D24111

--HG--
extra : moz-landing-system : lando

Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E \
    -e 's/throw ((["`])[^"]+\2);/throw new Error(\1);/g' \
    -e 's/throw ((["`])[^"]+\2 \+ [^ ";]+);/throw new Error(\1);/g' \
    -e 's/throw \(/throw new Error(/g' -i

Differential Revision: https://phabricator.services.mozilla.com/D24110

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D24107

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D21733

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D21732

--HG--
extra : moz-landing-system : lando

After this patch, invalid origin shouldn't block upgrade anymore. However, we
should be aware of that if an invild origin somehow can be recoverd to a valid
origin, then upgrade that origin is required.

Depends on D21730

Differential Revision: https://phabricator.services.mozilla.com/D21731

--HG--
extra : moz-landing-system : lando

Bug 1423917 - P6 - Having a test to verify the version2_1To2_2 upgrade removes obsolete origins and isn't blocked by an invalid origin; r=asuth

Depends on D21729

Differential Revision: https://phabricator.services.mozilla.com/D21730

--HG--
extra : moz-landing-system : lando

Depends on D21728

Differential Revision: https://phabricator.services.mozilla.com/D21729

--HG--
extra : moz-landing-system : lando

Depends on D21727

Differential Revision: https://phabricator.services.mozilla.com/D21728

--HG--
extra : moz-landing-system : lando