Skip to content
Snippets Groups Projects
  1. Jul 27, 2023
    • ma1's avatar
    • henry's avatar
      Bug 41736: Customize toolbar for tor-browser. · 03da74d0
      henry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      03da74d0
    • Dan Ballard's avatar
      Bug 40701: Add security warning when downloading a file · 450b7e8e
      Dan Ballard authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Shown in the downloads panel, about:downloads and places.xhtml.
      450b7e8e
    • Pier Angelo Vendrame's avatar
      Bug 41435: Add a Tor Browser migration function · 25fa2aec
      Pier Angelo Vendrame authored
      For now this function only deletes old language packs for which we are
      already packaging the strings with the application.
      25fa2aec
    • Pier Angelo Vendrame's avatar
      Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser · 6a83fe48
      Pier Angelo Vendrame authored
      This patch associates the about:manual page to a translated page that
      must be injected to browser/omni.ja after the build.
      The content must be placed in chrome/browser/content/browser/manual/, so
      that is then available at chrome://browser/content/manual/.
      We preferred giving absolute freedom to the web team, rather than having
      to change the patch in case of changes on the documentation.
      6a83fe48
    • Pier Angelo Vendrame's avatar
      Bug 40458: Implement .tor.onion aliases · 1f387301
      Pier Angelo Vendrame authored
      We have enabled HTTPS-Only mode, therefore we do not need
      HTTPS-Everywhere anymore.
      However, we want to keep supporting .tor.onion aliases (especially for
      securedrop).
      Therefore, in this patch we implemented the parsing of HTTPS-Everywhere
      rulesets, and the redirect of .tor.onion domains.
      Actually, Tor Browser believes they are actual domains. We change them
      on the fly on the SOCKS proxy requests to resolve the domain, and on
      the code that verifies HTTPS certificates.
      1f387301
    • Alex Catarineu's avatar
      Bug 21952: Implement Onion-Location · 1e3d7af6
      Alex Catarineu authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Whenever a valid Onion-Location HTTP header (or corresponding HTML
      <meta> http-equiv attribute) is found in a document load, we either
      redirect to it (if the user opted-in via preference) or notify the
      presence of an onionsite alternative with a badge in the urlbar.
      1e3d7af6
    • Kathleen Brade's avatar
      Bug 30237: Add v3 onion services client authentication prompt · 3002d6cb
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      When Tor informs the browser that client authentication is needed,
      temporarily load about:blank instead of about:neterror and prompt
      for the user's key.
      
      If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
      control port command to add the key (via Torbutton's control port
      module) and reload the page.
      
      If the user cancels the prompt, display the standard about:neterror
      "Unable to connect" page. This requires a small change to
      browser/actors/NetErrorChild.jsm to account for the fact that the
      docShell no longer has the failedChannel information. The failedChannel
      is used to extract TLS-related error info, which is not applicable
      in the case of a canceled .onion authentication prompt.
      
      Add a leaveOpen option to PopupNotifications.show so we can display
      error messages within the popup notification doorhanger without
      closing the prompt.
      
      Add support for onion services strings to the TorStrings module.
      
      Add support for Tor extended SOCKS errors (Tor proposal 304) to the
      socket transport and SOCKS layers. Improved display of all of these
      errors will be implemented as part of bug 30025.
      
      Also fixes bug 19757:
       Add a "Remember this key" checkbox to the client auth prompt.
      
       Add an "Onion Services Authentication" section within the
       about:preferences "Privacy & Security section" to allow
       viewing and removal of v3 onion client auth keys that have
       been stored on disk.
      
      Also fixes bug 19251: use enhanced error pages for onion service errors.
      3002d6cb
    • Richard Pospesel's avatar
      Bug 23247: Communicating security expectations for .onion · b234e10c
      Richard Pospesel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Encrypting pages hosted on Onion Services with SSL/TLS is redundant
      (in terms of hiding content) as all traffic within the Tor network is
      already fully encrypted.  Therefore, serving HTTP pages from an Onion
      Service is more or less fine.
      
      Prior to this patch, Tor Browser would mostly treat pages delivered
      via Onion Services as well as pages delivered in the ordinary fashion
      over the internet in the same way.  This created some inconsistencies
      in behaviour and misinformation presented to the user relating to the
      security of pages delivered via Onion Services:
      
       - HTTP Onion Service pages did not have any 'lock' icon indicating
         the site was secure
       - HTTP Onion Service pages would be marked as unencrypted in the Page
         Info screen
       - Mixed-mode content restrictions did not apply to HTTP Onion Service
         pages embedding Non-Onion HTTP content
      
      This patch fixes the above issues, and also adds several new 'Onion'
      icons to the mix to indicate all of the various permutations of Onion
      Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
      
      Strings for Onion Service Page Info page are pulled from Torbutton's
      localization strings.
      b234e10c
    • Alex Catarineu's avatar
      Bug 40073: Disable remote Public Suffix List fetching · 8167258f
      Alex Catarineu authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
      fetching the Public Suffix List via RemoteSettings and replacing the default
      one at runtime, which we do not want.
      8167258f
    • Mike Perry's avatar
      Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing · 933b4bfe
      Mike Perry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      eBay and Amazon don't treat Tor users very well. Accounts often get locked and
      payments reversed.
      
      Also:
      Bug 16322: Update DuckDuckGo search engine
      
      We are replacing the clearnet URL with an onion service one (thanks to a
      patch by a cypherpunk) and are removing the duplicated DDG search
      engine. Duplicating DDG happend due to bug 1061736 where Mozilla
      included DDG itself into Firefox. Interestingly, this caused breaking
      the DDG search if JavaScript is disabled as the Mozilla engine, which
      gets loaded earlier, does not use the html version of the search page.
      Moreover, the Mozilla engine tracked where the users were searching from
      by adding a respective parameter to the search query. We got rid of that
      feature as well.
      
      Also:
      This fixes bug 20809: the DuckDuckGo team has changed its server-side
      code in a way that lets users with JavaScript enabled use the default
      landing page while those without JavaScript available get redirected
      directly to the non-JS page. We adapt the search engine URLs
      accordingly.
      
      Also fixes bug 29798 by making sure we only specify the Google search
      engine we actually ship an .xml file for.
      
      Also regression tests.
      
      squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
      
      Bug 40494: Update Startpage search provider
      
      squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
      
      Bug 40438: Add Blockchair as a search engine
      
      Bug 33342: Avoid disconnect search addon error after removal.
      
      We removed the addon in #32767, but it was still being loaded
      from addonStartup.json.lz4 and throwing an error on startup
      because its resource: location is not available anymore.
      933b4bfe
    • Georg Koppen's avatar
      Bug 32658: Create a new MAR signing key · 767b3431
      Georg Koppen authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      It's time for our rotation again: Move the backup key in the front
      position and add a new backup key.
      
      Bug 33803: Move our primary nightly MAR signing key to tor-browser
      
      Bug 33803: Add a secondary nightly MAR signing key
      767b3431
    • Kathleen Brade's avatar
      Bug 16940: After update, load local change notes. · 1be01b50
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Add an about:tbupdate page that displays the first section from
      TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
      post-update page (typically our blog entry for the release).
      
      Always load about:tbupdate in a content process, but implement the
      code that reads the file system (changelog) in the chrome process
      for compatibility with future sandboxing efforts.
      
      Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
      changelog page that is designed to be displayed via a link that is on
      about:tor.
      1be01b50
    • Kathleen Brade's avatar
      Bug 19121: reinstate the update.xml hash check · a04d84b0
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      This is a partial revert of commit f1241db6.
      
      Revert most changes from Mozilla Bug 862173 "don't verify mar file hash
      when using mar signing to verify the mar file (lessens main thread I/O)."
      
      We kept the addition to the AppConstants API in case other JS code
      references it in the future.
      a04d84b0
    • Kathleen Brade's avatar
      Bug 12647: Support symlinks in the updater. · c0fadea5
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      c0fadea5
    • Pier Angelo Vendrame's avatar
      Bug 41668: Tweaks to the Base Browser updater for Tor Browser · 1b0c70f5
      Pier Angelo Vendrame authored
      This commit was once part of "Bug 4234: Use the Firefox Update Process
      for Tor Browser.".
      However, some parts of it were not needed for Base Browser and some
      derivative browsers.
      Therefore, we extracted from that commit the parts for Tor Browser
      legacy, and we add them back to the patch set with this commit.
      1b0c70f5
    • Arthur Edelstein's avatar
      Bug 12620: TorBrowser regression tests · 64597639
      Arthur Edelstein authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Regression tests for Bug #2950: Make Permissions Manager memory-only
      
      Regression tests for TB4: Tor Browser's Firefox preference overrides.
      
      Note: many more functional tests could be made here
      
      Regression tests for #2874: Block Components.interfaces from content
      
      Bug 18923: Add a script to run all Tor Browser specific tests
      
      Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
      64597639
    • Kathleen Brade's avatar
      Bug 7494: Create local home page for TBB. · bf71bd68
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      bf71bd68
    • Richard Pospesel's avatar
      Bug 27476: Implement about:torconnect captive portal within Tor Browser · d60d4929
      Richard Pospesel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      - implements new about:torconnect page as tor-launcher replacement
      - adds new torconnect component to browser
      - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
      - adds warning/error box to about:preferences#tor when not connected to tor
      
      Bug 40773: Update the about:torconnect frontend page to match additional UI flows.
      
      Bug 41608: Add a toolbar status button and a urlbar "Connect" button.
      d60d4929
    • Richard Pospesel's avatar
      Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection · b4cf177e
      Richard Pospesel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      This patch adds a new about:preferences#connection page which allows
      modifying bridge, proxy, and firewall settings from within Tor Browser.
      All of the functionality present in tor-launcher's Network
      Configuration panel is present:
      
       - Setting built-in bridges
       - Requesting bridges from BridgeDB via moat
       - Using user-provided bridges
       - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
       - Setting firewall ports
       - Viewing and Copying Tor's logs
       - The Networking Settings in General preferences has been removed
      
      Bug 40774: Update about:preferences page to match new UI designs
      b4cf177e
    • Pier Angelo Vendrame's avatar
      b18f8901
    • Kathleen Brade's avatar
      Bug 14631: Improve profile access error messages. · de3172d3
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Instead of always reporting that the profile is locked, display specific
      messages for "access denied" and "read-only file system".
      
      To allow for localization, get profile-related error strings from Torbutton.
      Use app display name ("Tor Browser") in profile-related error alerts.
      de3172d3
    • Alex Catarineu's avatar
      Add TorStrings module for localization · fd4486c3
      Alex Catarineu authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      fd4486c3
    • Matthew Finkel's avatar
      Bug 25741: TBA: Disable GeckoNetworkManager · f84eea90
      Matthew Finkel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      The browser should not need information related to the network
      interface or network state, tor should take care of that.
      f84eea90
    • Amogh Pradeep's avatar
      Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. · a34a0036
      Amogh Pradeep authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      See Bug 1357997 for partial uplift.
      
      Also:
      Bug 28051 - Use our Orbot for proxying our connections
      
      Bug 31144 - ESR68 Network Code Review
      a34a0036
    • ma1's avatar
      Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop · be4deedc
      ma1 authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Bug 41613: Skip Drang & Drop filtering for DNS-safe URLs
      be4deedc
    • henry's avatar
      Bug 41600: Add a tor circuit display panel. · dad80d9a
      henry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      dad80d9a
    • Arthur Edelstein's avatar
      Bug 3455: Add DomainIsolator, for isolating circuit by domain. · 493ce8c9
      Arthur Edelstein authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Add an XPCOM component that registers a ProtocolProxyChannelFilter
      which sets the username/password for each web request according to
      url bar domain.
      
      Bug 9442: Add New Circuit button
      
      Bug 13766: Set a 10 minute circuit dirty timeout for the catch-all circ.
      
      Bug 19206: Include a 128 bit random tag as part of the domain isolator nonce.
      
      Bug 19206: Clear out the domain isolator state on `New Identity`.
      
      Bug 21201.2: Isolate by firstPartyDomain from OriginAttributes
      
      Bug 21745: Fix handling of catch-all circuit
      
      Bug 41741: Refactor the domain isolator and new circuit
      493ce8c9
    • Alex Catarineu's avatar
      Bug 10760: Integrate TorButton to TorBrowser core · 42f5b8d7
      Alex Catarineu authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Because of the non-restartless nature of Torbutton, it required
      a two-stage installation process. On mobile, it was a problem,
      because it was not loading when the user opened the browser for
      the first time.
      
      Moving it to tor-browser and making it a system extension allows it
      to load when the user opens the browser for first time.
      
      Additionally, this patch also fixes Bug 27611.
      
      Bug 26321: New Circuit and New Identity menu items
      
      Bug 14392: Make about:tor behave like other initial pages.
      
      Bug 25013: Add torbutton as a tor-browser submodule
      
      Bug 31575: Replace Firefox Home (newtab) with about:tor
      42f5b8d7
    • Richard Pospesel's avatar
      Bug 40597: Implement TorSettings module · daf07d2b
      Richard Pospesel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      - migrated in-page settings read/write implementation from about:preferences#tor
        to the TorSettings module
      - TorSettings initially loads settings from the tor daemon, and saves them to
        firefox prefs
      - TorSettings notifies observers when a setting has changed; currently only
        QuickStart notification is implemented for parity with previous preference
        notify logic in about:torconnect and about:preferences#tor
      - about:preferences#tor, and about:torconnect now read and write settings
        thorugh the TorSettings module
      - all tor settings live in the torbrowser.settings.* preference branch
      - removed unused pref modify permission for about:torconnect content page from
        AsyncPrefs.jsm
      
      Bug 40645: Migrate Moat APIs to Moat.jsm module
      daf07d2b
    • Pier Angelo Vendrame's avatar
      ed2f93d4
    • Pier Angelo Vendrame's avatar
      Bug 13252: Customize profile management on macOS · c824681a
      Pier Angelo Vendrame authored
      On macOS we allow both portable mode and system installation.
      However, in the latter case, we customize Firefox's directories to
      match the hierarchy we use for the portable mode.
      
      Also, display an informative error message if the TorBrowser-Data
      directory cannot be created due to an "access denied" or a
      "read only volume" error.
      c824681a
    • Pier Angelo Vendrame's avatar
      Bug 40562: Added Tor Browser preferences to 000-tor-browser.js · 8deed10e
      Pier Angelo Vendrame authored
      Before reordering patches, we used to keep the Tor-related patches
      (torbutton and tor-launcher) at the beginning.
      After that issue, we decided to move them towards the end.
      
      In addition to that, we have decided to move Tor Browser-only
      preferences there, too, to make Base Browser-only fixups easier to
      apply.
      8deed10e
    • henry's avatar
      Bug 41340: Enable TOR_BROWSER_NIGHTLY_BUILD features for dev and nightly builds · c8357ebe
      henry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      tor-browser#41285: Enable fluent warnings.
      c8357ebe
    • Mike Perry's avatar
      TB3: Tor Browser's official .mozconfigs. · 86e41729
      Mike Perry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Also:
      Add an --enable-tor-browser-data-outside-app-dir configure option
      
      Add --with-tor-browser-version configure option
      
      Bug 31457: disable per-installation profiles
      
      The dedicated profiles (per-installation) feature does not interact
      well with our bundled profiles on Linux and Windows, and it also causes
      multiple profiles to be created on macOS under TorBrowser-Data.
      
      Bug 31935: Disable profile downgrade protection.
      
      Since Tor Browser does not support more than one profile, disable
      the prompt and associated code that offers to create one when a
      version downgrade situation is detected.
      
      Add --enable-tor-browser-update build option
      
      Bug 40793: moved Tor configuration options from old-configure.in to moz.configure
      
      Bug 41584: Move some configuration options to base-browser level
      86e41729
    • sanketh's avatar
      Bug 40209: Implement Basic Crypto Safety · 2730e4d8
      sanketh authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Adds a CryptoSafety actor which detects when you've copied a crypto
      address from a HTTP webpage and shows a warning.
      
      Closes #40209.
      
      Bug 40428: Fix string attribute names
      2730e4d8
    • Mike Perry's avatar
      Bug 2176: Rebrand Firefox to TorBrowser · cf1d39d2
      Mike Perry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      See also Bugs #5194, #7187, #8115, #8219.
      
      This patch does some basic renaming of Firefox to TorBrowser. The rest of the
      branding is done by images and icons.
      
      Also fix bug 27905.
      
      Bug 25702: Update Tor Browser icon to follow design guidelines
      
      - Updated all of the branding in /browser/branding/official with new 'stable'
      icon series.
      - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and
      add the source svg in the same directory
      - Copied /browser/branding/official over /browser/branding/nightly and the new
      /browser/branding/alpha directories. Replaced content with 'nightly' and
      'alpha' icon series.
      Updated VisualElements_70.png and VisualElements_150.png with updated icons in
      each branding directory (fixes #22654)
      - Updated firefox.VisualElementsManfiest.xml with updated colors in each
      branding directory
      - Added firefox.svg to each branding directory from which all the other icons
      are derived (apart from document.icns and document.ico)
      - Added default256.png and default512.png icons
      - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed
      original icon
      - Use the Tor Browser icon within devtools/client/themes/images/.
      
      Bug 30631: Blurry Tor Browser icon on macOS app switcher
      
      It would seem the png2icns tool does not generate correct icns files and
      so on macOS the larger icons were missing resulting in blurry icons in
      the OS chrome. Regenerated the padded icons in a macOS VM using
      iconutil.
      
      Bug 28196: preparations for using torbutton tor-browser-brand.ftl
      
      A small change to Fluent FileSource class is required so that we
      can register a new source without its supported locales being
      counted as available locales for the browser.
      
      Bug 31803: Replaced about:debugging logo with flat version
      
      Bug 21724: Make Firefox and Tor Browser distinct macOS apps
      
      When macOS opens a document or selects a default browser, it sometimes
      uses the CFBundleSignature. Changing from the Firefox MOZB signature to
      a different signature TORB allows macOS to distinguish between Firefox
      and Tor Browser.
      
      Bug 32092: Fix Tor Browser Support link in preferences
      
      For bug 40562, we moved onionPattern* from bug 27476 to here, as
      about:tor needs these files but it is included earlier.
      
      Bug 41278: Create Tor Browser styled pdf logo similar to the vanilla Firefox one
      cf1d39d2
    • Kathleen Brade's avatar
      Bug 11641: Disable remoting by default. · 845e2a11
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Unless the -osint command line flag is used, the browser now defaults
      to the equivalent of -no-remote.  There is a new -allow-remote flag that
      may be used to restore the original (Firefox-like) default behavior.
      845e2a11
    • henry's avatar
      Bug 41803: Add some developer tools for working on tor-browser. · a29b93c6
      henry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      a29b93c6
    • Richard Pospesel's avatar
      2546c1ce
Loading