Commit 7e25ac51 authored by Tom Ritter's avatar Tom Ritter Committed by Pier Angelo Vendrame
Browse files

Bug 1885258: Hidden fonts should obey the allow list r=jfkthame 

Differential Revision: https://phabricator.services.mozilla.com/D204571
parent 7c73b13f

gfx/thebes/gfxPlatformFontList.cpp

+1 −8
Original line number Diff line number Diff line
@@ -401,12 +401,6 @@ void gfxPlatformFontList::ApplyWhitelist() { 
  AutoTArray<RefPtr<gfxFontFamily>, 128> accepted;

  bool whitelistedFontFound = false;

  for (const auto& entry : mFontFamilies) {

    if (entry.GetData()->IsHidden()) {

      // Hidden system fonts are exempt from whitelisting, but don't count

      // towards determining whether we "kept" any (user-visible) fonts

      accepted.AppendElement(entry.GetData());

      continue;

    }

    nsAutoCString fontFamilyName(entry.GetKey());

    ToLowerCase(fontFamilyName);

    if (familyNamesWhitelist.Contains(fontFamilyName)) {
@@ -442,8 +436,7 @@ void gfxPlatformFontList::ApplyWhitelist( 
  AutoTArray<fontlist::Family::InitData, 128> accepted;

  bool keptNonHidden = false;

  for (auto& f : aFamilies) {

    if (f.mVisibility == FontVisibility::Hidden ||

        familyNamesWhitelist.Contains(f.mKey)) {

    if (familyNamesWhitelist.Contains(f.mKey)) {

      accepted.AppendElement(f);

      if (f.mVisibility != FontVisibility::Hidden) {

        keptNonHidden = true;