Skip to content
Snippets Groups Projects
  1. May 06, 2024
  2. Dec 09, 2021
  3. Dec 08, 2021
  4. Sep 02, 2020
    • Nathan Froyd's avatar
      Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg · cfb8fb31
      Nathan Froyd authored
      This patch was generated by running:
      
      ```
      perl -p -i \
           -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \
           -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \
           $FILE
      ```
      
      against every .cpp and .h in mozilla-central, and then fixing up the
      inevitable errors that happen as a result of matching C++ expressions with
      regexes.  The errors fell into three categories:
      
      1. Calling the convert functions with `std::string::c_str()`; these were
         changed to simply pass the string instead, relying on implicit conversion
         to `mozilla::Span`.
      2. Calling the convert functions with raw pointers, which is not permitted
         with the copy functions; these were changed to invoke `MakeStringSpan` first.
      3. Other miscellaneous errors resulting from over-eager regexes and/or the
         replacement not being type-aware.  These changes were reverted.
      
      Differential Revision: https://phabricator.services.mozilla.com/D88903
      cfb8fb31
  5. Aug 15, 2019
  6. Mar 13, 2019
  7. Feb 25, 2019
  8. Jan 18, 2019
  9. Jan 03, 2019
    • Emilio Cobos Álvarez's avatar
      Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug · d2ed2608
      Emilio Cobos Álvarez authored
      Summary: Really sorry for the size of the patch. It's mostly automatic
      s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
      add the right namespacing and such.
      
      Overall it's not a very interesting patch I think.
      
      nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
      nsIDocumentInlines.h into DocumentInlines.h.
      
      I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
      
      While fixing up some of the bits I also removed some unneeded OwnerDoc() null
      checks and such, but I didn't do anything riskier than that.
      d2ed2608
  10. Nov 30, 2018
  11. Nov 02, 2018
  12. Dec 07, 2017
  13. Nov 22, 2017
  14. Sep 24, 2017
  15. Mar 14, 2017
    • Zibi Braniecki's avatar
      Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use... · 3d91da87
      Zibi Braniecki authored
      Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
      
      In cases, where the caller is looking for the locale to be used for JS Intl API,
      we can now replace it with `undefined` which causes JS Intl API to use the default
      locale which since bug 1346674 is resolved to the app locale.
      
      This allows us to remove a lot of calls for the app locale.
      
      The remaining ones are split between `AsBCP47` and `AsLangTag`.
      Here, the `AsLangTag` is used, as described in the API docs, for cases where
      the language string is used for localization purposes, such as language negotaition
      matching to our language resources etc.
      `AsBCP47` is used when the returned value is handed over to ICU API.
      
      MozReview-Commit-ID: DzmFEUvMq3N
      
      --HG--
      extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
      3d91da87
  16. Mar 22, 2017
  17. Mar 14, 2017
    • Zibi Braniecki's avatar
      Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use... · c2cd68a6
      Zibi Braniecki authored
      Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
      
      In cases, where the caller is looking for the locale to be used for JS Intl API,
      we can now replace it with `undefined` which causes JS Intl API to use the default
      locale which since bug 1346674 is resolved to the app locale.
      
      This allows us to remove a lot of calls for the app locale.
      
      The remaining ones are split between `AsBCP47` and `AsLangTag`.
      Here, the `AsLangTag` is used, as described in the API docs, for cases where
      the language string is used for localization purposes, such as language negotaition
      matching to our language resources etc.
      `AsBCP47` is used when the returned value is handed over to ICU API.
      
      MozReview-Commit-ID: DzmFEUvMq3N
      
      --HG--
      extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
      c2cd68a6
  18. Oct 28, 2016
  19. Oct 06, 2015
  20. May 02, 2014
  21. Feb 20, 2014
  22. Jan 23, 2014
  23. May 02, 2014
  24. Feb 20, 2014
Loading