Skip to content
Snippets Groups Projects
  1. Jun 13, 2023
  2. Jul 27, 2023
  3. May 31, 2023
  4. May 24, 2023
  5. May 23, 2023
  6. May 20, 2023
  7. May 04, 2023
  8. May 02, 2023
  9. Apr 21, 2023
  10. Apr 06, 2023
  11. Apr 04, 2023
  12. Mar 27, 2023
  13. Mar 25, 2023
  14. Mar 24, 2023
  15. Mar 21, 2023
  16. Mar 20, 2023
    • Nika Layzell's avatar
      Bug 1823159 - Avoid racily initializing the PermissionManager twice during... · 431cede9
      Nika Layzell authored
      Bug 1823159 - Avoid racily initializing the PermissionManager twice during startup, r=timhuang,baku, a=dmeehan
      
      It appears that the issue is caused by a change in behaviour from bug
      1799470 which made the profile available earlier during startup. If the
      permission manager is started between the time when the profile becomes
      available and profile-do-change, it would've previously initialized
      without storage, and initialized storage after profile-do-change, but
      after the changes it may initialize twice instead.
      
      This patch changes the profile-do-change handler to check if we already
      have a profile, and avoid initializing the DB twice in that situation.
      
      Differential Revision: https://phabricator.services.mozilla.com/D173062
      431cede9
    • Nika Layzell's avatar
      Bug 1823159 - Avoid racily initializing the PermissionManager twice during startup, r=timhuang,baku · bebd2071
      Nika Layzell authored
      It appears that the issue is caused by a change in behaviour from bug
      1799470 which made the profile available earlier during startup. If the
      permission manager is started between the time when the profile becomes
      available and profile-do-change, it would've previously initialized
      without storage, and initialized storage after profile-do-change, but
      after the changes it may initialize twice instead.
      
      This patch changes the profile-do-change handler to check if we already
      have a profile, and avoid initializing the DB twice in that situation.
      
      Differential Revision: https://phabricator.services.mozilla.com/D173062
      bebd2071
    • Nika Layzell's avatar
      Bug 1823159 - Avoid racily initializing the PermissionManager twice during... · f4ff66f5
      Nika Layzell authored
      Bug 1823159 - Avoid racily initializing the PermissionManager twice during startup, r=timhuang,baku, a=dsmith
      
      It appears that the issue is caused by a change in behaviour from bug
      1799470 which made the profile available earlier during startup. If the
      permission manager is started between the time when the profile becomes
      available and profile-do-change, it would've previously initialized
      without storage, and initialized storage after profile-do-change, but
      after the changes it may initialize twice instead.
      
      This patch changes the profile-do-change handler to check if we already
      have a profile, and avoid initializing the DB twice in that situation.
      
      Differential Revision: https://phabricator.services.mozilla.com/D173062
      f4ff66f5
  17. Mar 03, 2023
    • Jan-Niklas Jaeschke's avatar
      Bug 1808565, part 1: Adapt `Selection` to support `StaticRange`s. r=webidl,saschanaz,masayuki,smaug · ebf3cd62
      Jan-Niklas Jaeschke authored
      This change is necessary to support the [CSS Highlight API](https://drafts.csswg.org/css-highlight-api-1/),
      which uses `Selection` internally.
      
      To replace `nsRange` with `AbstractRange`, some sections needed to be
      adapted since `nsRange`-specific features were used.
      Therefore, some methods (such as `GetRangeAt()`) may only be called if
      the `Selection` is *not* of type `SelectionType::eHighlight`,
      as it (per spec) returns an `nsRange`.
      These methods will now `MOZ_ASSERT` if called for a highlight selection.
      Additional methods are implemented which return `AbstractRange`
      instead and are safe to be called for every selection type.
      
      This commit also improves support of highlight features:
      - Invalidation of highlight ranges: adding/removing Ranges in-place instead of
        removing and re-adding the Selection object associated with the highlight.
      - Ranges are only associated with the Selection that shares the same Document
      - Fixed minor IDL issue
      
      Differential Revision: https://phabricator.services.mozilla.com/D170582
      ebf3cd62
  18. Mar 02, 2023
  19. Feb 21, 2023
    • Jan-Niklas Jaeschke's avatar
      Bug 1810403: Allow `nsRange`s to be in multiple `Selection`s. r=masayuki · 2243494a
      Jan-Niklas Jaeschke authored
      The Custom Highlight API allows a use case where a `Range` of a `Highlight`
      is also used as `Selection`. Due to the decision to use the `Selection` mechanism
      to display `Highlight`s, a `Range` can be part of several `Selection`s.
      Since the `Range` has a pointer to its associated `Selection`
      to notify about changes, this must be adapted to allow several `Selections`.
      
      As a tradeoff of performance and memory usage, the `Selection`s are stored
      as `mozilla::LinkedList`. A helper class `mozilla::SelectionListWrapper`
      was implemented to allow `Selection`s to be in multiple of these lists
      and without having to be derived from `LinkedListElement<T>`.
      
      To simplify usage of the list, the use case  "does this range belong to Selection x?"
      is wrapped into the convenience method`IsInSelection(Selection&)`;
      The method previously named like this was renamed to `IsInAnySelection()`
      to be named more precisely.
      
      Registering and unregistering of the closest common inclusive ancestor
      of the `Range` is done when the first `Selection` is registered and
      the last `Selection` is unregistered.
      
      Differential Revision: https://phabricator.services.mozilla.com/D169597
      2243494a
  20. Feb 14, 2023
  21. Feb 13, 2023
  22. Feb 14, 2023
  23. Jan 25, 2023
  24. Jan 09, 2023
  25. Jan 06, 2023
  26. Jan 05, 2023
  27. Jan 03, 2023
  28. Jan 02, 2023
Loading