- Jun 29, 2023
-
-
Mike Hommey authored
Bug 1840533 - Forbid @imports("__builtin__"). r=firefox-build-system-reviewers,andi,sergesanspaille, a=test-only DONTBUILD The last use of importing the whole __builtin__ module was removed in bug 1264831... 7 years ago. Now that it actually doesn't work anymore with recent releases of cpython, we might as well kill it for good. Differential Revision: https://phabricator.services.mozilla.com/D182140
-
- Jun 22, 2023
-
-
Mike Hommey authored
Bug 1839263 - Don't derive assertRaisesFromLine from assertRaises. r=firefox-build-system-reviewers,ahochheiden, a=test-only DONTBUILD In python 3.11 (maybe also 3.10, I haven't tested that version ; 3.9 was definitely different), by the time the context manager comes back in our assertRaisesFromLine, the traceback is not available anymore (or yet, I'm not entirely sure which way it does) to inspect and check the line numbers we want to check. And while assertRaises exposes the thrown exception in its `exception` attribute, it also resets the traceback associated with it, so we can't find it there either. So instead, we implement our own context manager for assertRaisesFromLine such that we can access that traceback. Differential Revision: https://phabricator.services.mozilla.com/D181425
-
Mike Hommey authored
Bug 1839263 - Fix python configure lint on python >= 3.10. r=firefox-build-system-reviewers,ahochheiden,sergesanspaille, a=test-only DONTBUILD Python 3.10 added some more arguments to the CodeTypes constructor. It also changed co_lnotab to co_linetables. We were using co_lnotab to simulate a function with a def at a specific line and a raise at a specific other line. I'm not sure how I ended up with this particular requirement (this may have been related to python 2 still being used back then), but as of now, it doesn't seem we need the def to be at a specific location, so we can avoid needing to generate a co_linetables/co_lnotab, relying instead on the raise expression being on the co_firstlineno+1 in the thrower function. As for the extra arguments, it turns out python 3.8 also introduced a CodeType.replace method that can be used to derive a CodeType object from another, which is certainly simpler than calling its construtor with the right set of arguments. Differential Revision: https://phabricator.services.mozilla.com/D181424
-
- Jul 27, 2023
-
-
Harshit Sohaney authored
-
- Feb 05, 2024
-
-
serge-sans-paille authored
distutils is no longer available in Python 3.12, which means we cannot require it on bootstrap, otherwise we cannot bootstrap from Py 3.12. We already require setuptools as part of mach's requirements, so it's fine to depend on setuptools elsewhere. Original Revision: https://phabricator.services.mozilla.com/D190537 Differential Revision: https://phabricator.services.mozilla.com/D200113
-
serge-sans-paille authored
distutils have been removed from Python 3.12, so replace it: Sometimes using packaging's Version, sometimes providing our own in the case of mozrelease/versions.py. Add more tests for the latter. Original Revision: https://phabricator.services.mozilla.com/D190540 Differential Revision: https://phabricator.services.mozilla.com/D200111
-
ahochheiden authored
There's a `Cython` issue (https://github.com/yaml/pyyaml/issues/601) with `PyYAML` that breaks our `./mach vendor python` in versions of PyYAML `>5.3.1` and `=<6.0`. This issue has been resolved with `PyYAML` version `6.0.1`, and we can just safely upgrade to it (rather than downgrading to `5.3.1` (which has other issues). Original Revision: https://phabricator.services.mozilla.com/D183818 Differential Revision: https://phabricator.services.mozilla.com/D200108
-
serge-sans-paille authored
Following the official migration guide from https://docs.python.org/3/whatsnew/3.12.html#imp Original Revision: https://phabricator.services.mozilla.com/D190465 Differential Revision: https://phabricator.services.mozilla.com/D200107
-
- Nov 29, 2023
-
-
Mike Conley authored
Bug 1867346 - Tweak strings for ASRouter spotlight message to encourage users without FxA accounts to create one. r=fluent-reviewers,flod, a=dmeehan, l10n=flod Differential Revision: https://phabricator.services.mozilla.com/D195013
-
- Dec 12, 2023
-
-
Mike Hommey authored
prewarming the AVDs was done for CI, where AVDs are used only once in each task using them, and the cost of first use is high. Prewarming reduces that overhead. However, the ARM AVD is not used on CI (anymore?), so we don't need them prewarmed. This unblocks the situation wrt the failure to run the emulator on CI, while not addressing the underlying issues, so that CoT keys can be rotated without waiting for the full situation to be resolved. Differential Revision: https://phabricator.services.mozilla.com/D195820
-
- Jan 03, 2024
-
-
donal meehan authored
-
Mike Conley authored
Bug 1866295 - Land new strings for ASRouter spotlight message to encourage users without FxA accounts to create one. a=dmeehan Original Revision: https://phabricator.services.mozilla.com/D194553 Differential Revision: https://phabricator.services.mozilla.com/D197601
-
- Dec 14, 2023
-
-
Mike Hommey authored
Differential Revision: https://phabricator.services.mozilla.com/D196378
-
- Sep 18, 2023
-
-
Steve Fink authored
Differential Revision: https://phabricator.services.mozilla.com/D188302
-
- Jun 07, 2023
-
-
Mike Hommey authored
This moves the creation of both rlbox.wasm.c and rlbox.wasm.h to pre-compile, which allows static-analysis to create both files (but more importantly the .h) without also compiling rlbox.wasm.c, which takes forever. Differential Revision: https://phabricator.services.mozilla.com/D180173
-
- Jul 07, 2023
-
-
Mike Hommey authored
Bug 1841585 - Generate webrtc moz.build snippets for mipsel and mips64el. r=webrtc-reviewers,mjf a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D182702
-
- Jun 28, 2023
-
-
Makoto Kato authored
If `use_sysroot` is false (see libwebrtc/build/config/sysroot.gni. true if Google's server has sysroot image), webrtc will causes build error since `rtc_use_pipewire` is false. But since `rtc_use_x11_extensions` is true, we should include some dirs/files in source files. So I add more MOZ_X11 condition for `rtc_use_x11_extensions`. Differential Revision: https://phabricator.services.mozilla.com/D176752
-
- Jun 13, 2023
-
-
Heitor Neiva authored
Bug 1836078 - Update taskgraph to support comm-esr115 r=rjl,releng-reviewers,taskgraph-reviewers,jcristau, a=dmeehan Depends on D180026 Differential Revision: https://phabricator.services.mozilla.com/D180027
-
- Jun 09, 2023
-
-
Heitor Neiva authored
Bug 1836078 - Update gecko taskgraph to support ESR115 r=releng-reviewers,taskgraph-reviewers,jcristau, a=release Differential Revision: https://phabricator.services.mozilla.com/D180026
-
- Jun 02, 2023
-
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D179456
-
Kelly Cochrane authored
Bug 1832668 - Add new side navigation component to Firefox View Next page r=fxview-reviewers,fluent-reviewers,flod,sfoster Differential Revision: https://phabricator.services.mozilla.com/D179215
-
- Jun 01, 2023
-
-
Mike Hommey authored
Bug 1834436 - Upgrade minimum supported GCC version to 8. r=firefox-build-system-reviewers,sergesanspaille Differential Revision: https://phabricator.services.mozilla.com/D178736
-
- May 31, 2023
-
-
Mike Hommey authored
For larger packages (e.g. Xcode), it makes a big difference. Differential Revision: https://phabricator.services.mozilla.com/D179283
-
Mike Hommey authored
Differential Revision: https://phabricator.services.mozilla.com/D179281
-
Rob Wu authored
Bug 1835559 - Ensure that text content survives translation r=application-update-reviewers,flod,fluent-reviewers,nalexander,settings-reviewers,Gijs When an element is re-translated, the textContent is currently dropped. To avoid that, make it an explicit part of the message. This requires changing the l10n message ID. Ideally, the message ID wouldn't change, but that is not possible until the content can be preserved as a feature, i.e. https://github.com/projectfluent/fluent.js/issues/169 Differential Revision: https://phabricator.services.mozilla.com/D179323
-
Cosmin Sabou authored
Backed out changeset 81758aba6ab3 (bug 1835559) for causing bc failures on browser_aboutDialog_fc_downloadOptIn.js. CLOSED TREE
-
Rob Wu authored
Bug 1835559 - Ensure that text content survives translation r=application-update-reviewers,flod,fluent-reviewers,nalexander,settings-reviewers,Gijs When an element is re-translated, the textContent is currently dropped. To avoid that, make it an explicit part of the message. This requires changing the l10n message ID. Ideally, the message ID wouldn't change, but that is not possible until the content can be preserved as a feature, i.e. https://github.com/projectfluent/fluent.js/issues/169 Differential Revision: https://phabricator.services.mozilla.com/D179323
-
Natalia Csoregi authored
-
valenting authored
Differential Revision: https://phabricator.services.mozilla.com/D179456
-
- May 30, 2023
-
-
Tooru Fujisawa authored
Bug 1834673 - Part 2: Replace incompatible characters in LCOV error reporting. r=ahochheiden,firefox-build-system-reviewers Differential Revision: https://phabricator.services.mozilla.com/D179052
-
Tooru Fujisawa authored
Differential Revision: https://phabricator.services.mozilla.com/D179051
-
- May 29, 2023
-
-
Mike Hommey authored
Bug 1834955 - Upgrade minimum supported Clang-cl version to 9. r=firefox-build-system-reviewers,sergesanspaille We have less constraints on the minimum supported clang-cl version, and it would unlock C++17 inline variables (which had a bug on Windows targets in clang up-to 8.x). Differential Revision: https://phabricator.services.mozilla.com/D179037
-
Mike Hommey authored
Its implementation in python3 is just wrapping pprint.pprint, and there's only one use. The python2 implementation is obviously dead code. Differential Revision: https://phabricator.services.mozilla.com/D179179
-
Eemeli Aro authored
Bug 1831872 - Migrate client.name2 string from sync.properties to Fluent. r=markh,fluent-reviewers,geckoview-reviewers,sync-reviewers,flod,m_kato As this is the only string in `services/`, let's simplify by moving it under `toolkit/` and removing `services/sync/locales/` as empty. On advice from markh, the ON_NEW_DEVICE_ID notification is delayed during device registration & updates until the update has been written to storage. Differential Revision: https://phabricator.services.mozilla.com/D178805
-
- May 26, 2023
-
-
Gabriele Svelto authored
Differential Revision: https://phabricator.services.mozilla.com/D179070
-
Mike Hommey authored
Differential Revision: https://phabricator.services.mozilla.com/D178734
-
- May 25, 2023
-
-
Mark Banner authored
Bug 1834967 - Add HTML to the list of items to automatically format with Prettier in VS Code. r=firefox-build-system-reviewers,nalexander Differential Revision: https://phabricator.services.mozilla.com/D179042
-
Mike Hommey authored
Bug 1833998 - Switch Firefox builds to macOS 13.3 SDK. r=firefox-build-system-reviewers,sergesanspaille Differential Revision: https://phabricator.services.mozilla.com/D178500
-
- May 24, 2023
-
-
ahochheiden authored
Bug 1833448 - Mention that the `configure mercurial` step also updates `version-control-tools` r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D178830
-
- May 23, 2023
-
-
Heitor Neiva authored
Differential Revision: https://phabricator.services.mozilla.com/D176162
-